You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2016/05/23 22:41:38 UTC
Review Request 47745: remove sqlf code in GemFireCacheImpl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47745/
-----------------------------------------------------------
Review request for geode, Eric Shu and Sai Boorlagadda.
Bugs: GEODE-1426
https://issues.apache.org/jira/browse/GEODE-1426
Repository: geode
Description
-------
The sqlf instance variables and all subsequent callers of them have been removed.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/cache/AttributesFactory.java fe7910a2028cbaff6d6bd796a326722c43e3600c
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 91fa558144d18d22b6e563c9286dc47fa77ac5af
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java e3f1050945c554c3ab7ce916280ffd8939dad487
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 5248d3d89fd5c61bad82e25c2299a5a18a453fea
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerImpl.java edc44d38bbc100d31458e4c957a859ad80791c24
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ControllerAdvisor.java ab03d8c5316b346217b166c545026eab9d548a16
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntriesSet.java e527d395010095c0c4ac7f4be3fcb054b494f0b8
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java b833ecb8b629a34870bd495ef4ed5f4f039dfa81
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java c44f3b7bab1b65770431dbc2d3c08991ee5ce008
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GridAdvisor.java 7c7ac12c16f03a733dcf003caf9bdf8045543c08
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java d28496cc6e58cf061ce996d45526f3a0bd3ab10f
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java 4460a8afb46df4005c9fe3cb2303e85e37d18353
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRemoteCommitMessage.java cd75864d2f60b0eb8810c6988da3f2e970e48e5b
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java 617873c0553b7ea064f7ffbb4f59c347405efbd9
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImpl.java eeb611e339ac1545f46c314bb19dfd329115c0d2
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/ServerConnection.java e608db3c18047421a03578d96798379b86dd1a65
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java fce11755c774269a5cbdc907565aaa2fc4f53952
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Put.java 35cc085067cc4dd8086a070e16862b3dc7482cf6
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Put61.java cc4c1d6e041b7b7f8c0c26ba51b192857d4e6f1a
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Put65.java 9be1390afbeceae4b4f2c385bfed76969f1e2d7a
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java 8f922a0299ead806b5742dd8f3bfa9de2b21c3ad
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImplJUnitTest.java e43797c1b6e657554c51a920fc03700e6b3ae2d5
geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt b8ef985ec37260eb741aed6e0bf177247af84a77
Diff: https://reviews.apache.org/r/47745/diff/
Testing
-------
precheckin
Thanks,
Darrel Schneider
Re: Review Request 47745: remove sqlf code in GemFireCacheImpl
Posted by Eric Shu <es...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47745/#review134613
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java (line 920)
<https://reviews.apache.org/r/47745/#comment199456>
This comment can be removed.
- Eric Shu
On May 23, 2016, 10:41 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47745/
> -----------------------------------------------------------
>
> (Updated May 23, 2016, 10:41 p.m.)
>
>
> Review request for geode, Eric Shu and Sai Boorlagadda.
>
>
> Bugs: GEODE-1426
> https://issues.apache.org/jira/browse/GEODE-1426
>
>
> Repository: geode
>
>
> Description
> -------
>
> The sqlf instance variables and all subsequent callers of them have been removed.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/AttributesFactory.java fe7910a2028cbaff6d6bd796a326722c43e3600c
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 91fa558144d18d22b6e563c9286dc47fa77ac5af
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java e3f1050945c554c3ab7ce916280ffd8939dad487
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 5248d3d89fd5c61bad82e25c2299a5a18a453fea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerImpl.java edc44d38bbc100d31458e4c957a859ad80791c24
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ControllerAdvisor.java ab03d8c5316b346217b166c545026eab9d548a16
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntriesSet.java e527d395010095c0c4ac7f4be3fcb054b494f0b8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java b833ecb8b629a34870bd495ef4ed5f4f039dfa81
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java c44f3b7bab1b65770431dbc2d3c08991ee5ce008
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GridAdvisor.java 7c7ac12c16f03a733dcf003caf9bdf8045543c08
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java d28496cc6e58cf061ce996d45526f3a0bd3ab10f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java 4460a8afb46df4005c9fe3cb2303e85e37d18353
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRemoteCommitMessage.java cd75864d2f60b0eb8810c6988da3f2e970e48e5b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java 617873c0553b7ea064f7ffbb4f59c347405efbd9
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImpl.java eeb611e339ac1545f46c314bb19dfd329115c0d2
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/ServerConnection.java e608db3c18047421a03578d96798379b86dd1a65
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java fce11755c774269a5cbdc907565aaa2fc4f53952
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Put.java 35cc085067cc4dd8086a070e16862b3dc7482cf6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Put61.java cc4c1d6e041b7b7f8c0c26ba51b192857d4e6f1a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Put65.java 9be1390afbeceae4b4f2c385bfed76969f1e2d7a
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java 8f922a0299ead806b5742dd8f3bfa9de2b21c3ad
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImplJUnitTest.java e43797c1b6e657554c51a920fc03700e6b3ae2d5
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt b8ef985ec37260eb741aed6e0bf177247af84a77
>
> Diff: https://reviews.apache.org/r/47745/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 47745: remove sqlf code in GemFireCacheImpl
Posted by Sai Boorlagadda <sb...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47745/#review134629
-----------------------------------------------------------
Ship it!
Ship It!
- Sai Boorlagadda
On May 23, 2016, 10:41 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47745/
> -----------------------------------------------------------
>
> (Updated May 23, 2016, 10:41 p.m.)
>
>
> Review request for geode, Eric Shu and Sai Boorlagadda.
>
>
> Bugs: GEODE-1426
> https://issues.apache.org/jira/browse/GEODE-1426
>
>
> Repository: geode
>
>
> Description
> -------
>
> The sqlf instance variables and all subsequent callers of them have been removed.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/AttributesFactory.java fe7910a2028cbaff6d6bd796a326722c43e3600c
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 91fa558144d18d22b6e563c9286dc47fa77ac5af
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java e3f1050945c554c3ab7ce916280ffd8939dad487
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 5248d3d89fd5c61bad82e25c2299a5a18a453fea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerImpl.java edc44d38bbc100d31458e4c957a859ad80791c24
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ControllerAdvisor.java ab03d8c5316b346217b166c545026eab9d548a16
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntriesSet.java e527d395010095c0c4ac7f4be3fcb054b494f0b8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java b833ecb8b629a34870bd495ef4ed5f4f039dfa81
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java c44f3b7bab1b65770431dbc2d3c08991ee5ce008
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GridAdvisor.java 7c7ac12c16f03a733dcf003caf9bdf8045543c08
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java d28496cc6e58cf061ce996d45526f3a0bd3ab10f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java 4460a8afb46df4005c9fe3cb2303e85e37d18353
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRemoteCommitMessage.java cd75864d2f60b0eb8810c6988da3f2e970e48e5b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java 617873c0553b7ea064f7ffbb4f59c347405efbd9
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImpl.java eeb611e339ac1545f46c314bb19dfd329115c0d2
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/ServerConnection.java e608db3c18047421a03578d96798379b86dd1a65
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java fce11755c774269a5cbdc907565aaa2fc4f53952
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Put.java 35cc085067cc4dd8086a070e16862b3dc7482cf6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Put61.java cc4c1d6e041b7b7f8c0c26ba51b192857d4e6f1a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Put65.java 9be1390afbeceae4b4f2c385bfed76969f1e2d7a
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java 8f922a0299ead806b5742dd8f3bfa9de2b21c3ad
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImplJUnitTest.java e43797c1b6e657554c51a920fc03700e6b3ae2d5
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt b8ef985ec37260eb741aed6e0bf177247af84a77
>
> Diff: https://reviews.apache.org/r/47745/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>