You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "gupta-sahil01 (via GitHub)" <gi...@apache.org> on 2026/07/27 16:31:26 UTC

[I] Add a confirmation dialog when removing a package from an environment [texera]

gupta-sahil01 opened a new issue, #6937:
URL: https://github.com/apache/texera/issues/6937

   ### Task Summary
   
   Clicking the trash icon next to a package in an environment currently only marks it (turns it red) and doesn't remove it until the user clicks Save — which is confusing, since a trash icon implies immediate removal.
   
   As agreed in discussion #6725, clicking the trash icon should open a confirmation dialog. On confirm, the package is removed from the list; on cancel, it stays unchanged. This keeps the existing trash-icon pattern while making the delete workflow unambiguous, without adding UI clutter (checkboxes / "Delete Selected").
   
   Discussed in #6725.
   
   ### Task Type
   
   - [ ] Refactor / Cleanup
   - [ ] DevOps / Deployment / CI
   - [ ] Testing / QA
   - [ ] Documentation
   - [ ] Performance
   - [x] Other


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add a confirmation dialog when removing a package from an environment [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan closed issue #6937: Add a confirmation dialog when removing a package from an environment
URL: https://github.com/apache/texera/issues/6937


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add a confirmation dialog when removing a package from an environment [texera]

Posted by "gupta-sahil01 (via GitHub)" <gi...@apache.org>.
gupta-sahil01 commented on issue #6937:
URL: https://github.com/apache/texera/issues/6937#issuecomment-5187074987

   @SarahAsad23 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add a confirmation dialog when removing a package from an environment [texera]

Posted by "gupta-sahil01 (via GitHub)" <gi...@apache.org>.
gupta-sahil01 commented on issue #6937:
URL: https://github.com/apache/texera/issues/6937#issuecomment-5160224921

   So what should be the features of the "install" button? Should it run something else in the background or keep the same as what "save" was doing?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add a confirmation dialog when removing a package from an environment [texera]

Posted by "SarahAsad23 (via GitHub)" <gi...@apache.org>.
SarahAsad23 commented on issue #6937:
URL: https://github.com/apache/texera/issues/6937#issuecomment-5136789221

   This looks good to me. Is the package deleted right after confirmation or does the user still have to press “save”? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add a confirmation dialog when removing a package from an environment [texera]

Posted by "SarahAsad23 (via GitHub)" <gi...@apache.org>.
SarahAsad23 commented on issue #6937:
URL: https://github.com/apache/texera/issues/6937#issuecomment-5187360189

   Currently in the backend, the save button first uninstalls all the packages that have been marked for deletion and outputs the corresponding pip output. It then does the install of newly added packages. This all happens in one go after saving. 
   
   This should be decoupled. Deletion should happen right after the user confirms and we should also stream the pip output. Install can then just install the packages the user added (if any) and also stream the corresponding pip output. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add a confirmation dialog when removing a package from an environment [texera]

Posted by "gupta-sahil01 (via GitHub)" <gi...@apache.org>.
gupta-sahil01 commented on issue #6937:
URL: https://github.com/apache/texera/issues/6937#issuecomment-5099766238

   <img width="1279" height="400" alt="Image" src="https://github.com/user-attachments/assets/6afb8b0a-6437-49ec-8f4d-100d0a597b76" />
   
   Can I get some thoughts on this @SarahAsad23 @Neilk1021 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add a confirmation dialog when removing a package from an environment [texera]

Posted by "gupta-sahil01 (via GitHub)" <gi...@apache.org>.
gupta-sahil01 commented on issue #6937:
URL: https://github.com/apache/texera/issues/6937#issuecomment-5195550359

   @SarahAsad23 Thanks, I want to check the scope before I build this, because I hit two things. I've implemented the dialog in `user-venv.component.ts` (the dashboard Environments page). Right now confirming just drops the row from the local draft; Save still PUTs the full package map to `/pve/db/{veid}`, so the backend does the uninstall+install reconciliation you described.
   
   So: were you describing the computing-unit panel rather than the dashboard Environments page? And if you do mean the dashboard page — should this issue expand to cover the backend streaming change, or would you prefer the confirmation dialog land as-is (matching the issue as filed) with the decoupling tracked separately?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add a confirmation dialog when removing a package from an environment [texera]

Posted by "SarahAsad23 (via GitHub)" <gi...@apache.org>.
SarahAsad23 commented on issue #6937:
URL: https://github.com/apache/texera/issues/6937#issuecomment-5155631482

   Yes, but I suggest we change the save button to say something like “install” as that’s the main purpose of the button now. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add a confirmation dialog when removing a package from an environment [texera]

Posted by "SarahAsad23 (via GitHub)" <gi...@apache.org>.
SarahAsad23 commented on issue #6937:
URL: https://github.com/apache/texera/issues/6937#issuecomment-5195692321

   You’re right that the dashboard page just saves the packages in the db. You can make the UI change as is. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add a confirmation dialog when removing a package from an environment [texera]

Posted by "gupta-sahil01 (via GitHub)" <gi...@apache.org>.
gupta-sahil01 commented on issue #6937:
URL: https://github.com/apache/texera/issues/6937#issuecomment-5138557439

   The package gets deleted right after confirmation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add a confirmation dialog when removing a package from an environment [texera]

Posted by "gupta-sahil01 (via GitHub)" <gi...@apache.org>.
gupta-sahil01 commented on issue #6937:
URL: https://github.com/apache/texera/issues/6937#issuecomment-5154475783

   Should I raise a PR for this @SarahAsad23 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add a confirmation dialog when removing a package from an environment [texera]

Posted by "gupta-sahil01 (via GitHub)" <gi...@apache.org>.
gupta-sahil01 commented on issue #6937:
URL: https://github.com/apache/texera/issues/6937#issuecomment-5121333935

   @SarahAsad23 @Neilk1021, your thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add a confirmation dialog when removing a package from an environment [texera]

Posted by "gupta-sahil01 (via GitHub)" <gi...@apache.org>.
gupta-sahil01 commented on issue #6937:
URL: https://github.com/apache/texera/issues/6937#issuecomment-5097364388

   /take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org