You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Nguyen Truong <ng...@gmail.com> on 2018/08/07 09:33:53 UTC
Review Request 68254: Change MainframeImportTool to refer to
MainframeManager class directly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68254/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-3357
https://issues.apache.org/jira/browse/SQOOP-3357
Repository: sqoop-trunk
Description
-------
MainframeImportTool used to refer to the MainframeManager with a string. I changed the string to a MainframeManager class reference.
Diffs
-----
src/java/org/apache/sqoop/tool/MainframeImportTool.java 8883301d
src/test/org/apache/sqoop/manager/TestMainframeManager.java 97e48e88
Diff: https://reviews.apache.org/r/68254/diff/1/
Testing
-------
I ran ant test and did not add any more test case because my change was already covered.
Thanks,
Nguyen Truong
Re: Review Request 68254: Change MainframeImportTool to refer to
MainframeManager class directly
Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68254/#review207024
-----------------------------------------------------------
Ship it!
Ship It!
- Fero Szabo
On Aug. 7, 2018, 9:33 a.m., Nguyen Truong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68254/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 9:33 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3357
> https://issues.apache.org/jira/browse/SQOOP-3357
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> MainframeImportTool used to refer to the MainframeManager with a string. I changed the string to a MainframeManager class reference.
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/tool/MainframeImportTool.java 8883301d
> src/test/org/apache/sqoop/manager/TestMainframeManager.java 97e48e88
>
>
> Diff: https://reviews.apache.org/r/68254/diff/1/
>
>
> Testing
> -------
>
> I ran ant test and did not add any more test case because my change was already covered.
>
>
> Thanks,
>
> Nguyen Truong
>
>
Re: Review Request 68254: Change MainframeImportTool to refer to
MainframeManager class directly
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68254/#review207038
-----------------------------------------------------------
Ship it!
Ship It!
- Szabolcs Vasas
On Aug. 7, 2018, 9:33 a.m., Nguyen Truong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68254/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 9:33 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3357
> https://issues.apache.org/jira/browse/SQOOP-3357
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> MainframeImportTool used to refer to the MainframeManager with a string. I changed the string to a MainframeManager class reference.
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/tool/MainframeImportTool.java 8883301d
> src/test/org/apache/sqoop/manager/TestMainframeManager.java 97e48e88
>
>
> Diff: https://reviews.apache.org/r/68254/diff/1/
>
>
> Testing
> -------
>
> I ran ant test and did not add any more test case because my change was already covered.
>
>
> Thanks,
>
> Nguyen Truong
>
>
Re: Review Request 68254: Change MainframeImportTool to refer to
MainframeManager class directly
Posted by Boglarka Egyed <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68254/#review207035
-----------------------------------------------------------
Ship it!
Thanks for this fix Nguyen!
- Boglarka Egyed
On Aug. 7, 2018, 9:33 a.m., Nguyen Truong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68254/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 9:33 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3357
> https://issues.apache.org/jira/browse/SQOOP-3357
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> MainframeImportTool used to refer to the MainframeManager with a string. I changed the string to a MainframeManager class reference.
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/tool/MainframeImportTool.java 8883301d
> src/test/org/apache/sqoop/manager/TestMainframeManager.java 97e48e88
>
>
> Diff: https://reviews.apache.org/r/68254/diff/1/
>
>
> Testing
> -------
>
> I ran ant test and did not add any more test case because my change was already covered.
>
>
> Thanks,
>
> Nguyen Truong
>
>