You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/31 15:08:16 UTC
[GitHub] kiszk commented on a change in pull request #23420:
[SPARK-26508][Core][SQL] Address warning messages in Java reported at
lgtm.com
kiszk commented on a change in pull request #23420: [SPARK-26508][Core][SQL] Address warning messages in Java reported at lgtm.com
URL: https://github.com/apache/spark/pull/23420#discussion_r244592673
##########
File path: core/src/main/scala/org/apache/spark/package.scala
##########
@@ -76,7 +76,9 @@ package object spark {
)
} catch {
case e: Exception =>
- throw new SparkException("Error loading properties from spark-version-info.properties", e)
+ // throw new SparkException("Error loading properties from spark-version-info.properties", e)
+ val unknownProp = "<unknown>"
+ (unknownProp, unknownProp, unknownProp, unknownProp, unknownProp, unknownProp)
Review comment:
Thank you, this is my mistake. I will revert this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org