You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2022/05/10 14:05:19 UTC
[GitHub] [jena] afs commented on a diff in pull request #1273: Added GraphMemUsingHashMap (faster and needs less memory) to replace GraphMem
afs commented on code in PR #1273:
URL: https://github.com/apache/jena/pull/1273#discussion_r869280535
##########
jena-core/src/main/java/org/apache/jena/graph/Factory.java:
##########
@@ -40,11 +40,11 @@ public static Graph createDefaultGraph()
{ return Factory.createGraphMem( ); }
public static Graph createGraphMem()
- { return new GraphMem(); }
+ { return new GraphMemUsingHashMap(); }
public static Graph createGraphMemWithTransactionHandler( final TransactionHandler th )
{
- Graph g = new GraphMem()
+ Graph g = new GraphMemUsingHashMap()
Review Comment:
I don't see a way to do this because application code is mostly calling "createDefaultModel" so it is oblivious to the implementation choice. There are some deprecations in 4.4.0 for code directly using GraphMem (which it shouldn't be!).
##########
jena-core/src/main/java/org/apache/jena/graph/Factory.java:
##########
@@ -40,11 +40,11 @@ public static Graph createDefaultGraph()
{ return Factory.createGraphMem( ); }
public static Graph createGraphMem()
- { return new GraphMem(); }
+ { return new GraphMemUsingHashMap(); }
public static Graph createGraphMemWithTransactionHandler( final TransactionHandler th )
{
- Graph g = new GraphMem()
+ Graph g = new GraphMemUsingHashMap()
Review Comment:
See also discussion: https://github.com/apache/jena/pull/1273#issuecomment-1112634490
I'll mark this resolved and lets' continue the migration discussion on the overall thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org