You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/04/14 00:15:52 UTC
[GitHub] [ozone] neils-dev opened a new pull request #2153: HDDS-5068. build errors due to missing JAXB-runtime jar dependency for openjdk 11 se standalone
neils-dev opened a new pull request #2153:
URL: https://github.com/apache/ozone/pull/2153
## What changes were proposed in this pull request?
Added maven build dependency _jaxb-runtime_ to each _pom.xml_ file in ozone build that requires _jaxb-api_ dependency. Changes made to compile and run with Java 11 see _**https://javaee.github.io/jaxb-v2/doc/user-guide/ch03.html#deployment-maven-coordinates**_. In summary,
`If client application needs to include the runtime, e.g. running standalone on JavaSE jaxb-runtime should be also included.
`
Fixes java 11 compile issues for unit testing ie. _hadoop-ozone/tools_ as well as ozone runtime commands such as _getconf_.
Made small changes to fix unit test: _hadoop-hdds/container-service/TestContainerData.Yaml_. With java 11 compile, unit test fails due to comparison between expected and actual container date/time. Failure occurs because time in date/time is truncated (precision error) in comparison. Change _to use_ timestamp epochs in milliseconds.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5068
## How was this patch tested?
Build without errors :
`mvn clean install -Phdds -DskipTests=true -Dmaven.javadoc.skip=true -Pdist -Dtar -DskipShade`
and,
`hadoop-ozone/dev-support/checks/unit.sh`
with clean hadoop-hdds/container-service tests after patch for TestContainerDataYaml
**Note:** observed _intermittent errors_ associated with _hdds-container-service_: _TestSchemaOneBackwardsCompatibility_ (problem due to thread-pool dispatching a non-blocking thread when testcase expects a blocking thread; thread is not finished when test checks condition hence intermittent error).
with fixed errors :
**Also** tested with ozone getconf command (passes with patch, see jira for error reported by **@elek** ):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek commented on a change in pull request #2153: HDDS-5068. build errors due to missing JAXB-runtime jar dependency for openjdk 11 se standalone
Posted by GitBox <gi...@apache.org>.
elek commented on a change in pull request #2153:
URL: https://github.com/apache/ozone/pull/2153#discussion_r617355131
##########
File path: hadoop-ozone/dist/src/main/license/bin/LICENSE.txt
##########
@@ -228,12 +228,12 @@ BSD
CDDL
=====================
+ com.sun.istack:istack-commons-runtime
com.sun.jersey:jersey-core
com.sun.jersey:jersey-json
com.sun.jersey:jersey-server
com.sun.jersey:jersey-servlet
com.sun.xml.bind:jaxb-core
Review comment:
Yep. We already have the line for the new jaxb-core: `org.glassfish.jaxb:jaxb-core`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] neils-dev commented on pull request #2153: HDDS-5068. build errors due to missing JAXB-runtime jar dependency for openjdk 11 se standalone
Posted by GitBox <gi...@apache.org>.
neils-dev commented on pull request #2153:
URL: https://github.com/apache/ozone/pull/2153#issuecomment-819956555
Thanks **@adoroszlai** for comments on classpath jars resulting from pom build file changes for _jaxb_ upgrade. Yes, unintentionally included is the _org.glassfish jaxb-core_. Apparently it is pulled in from the _org.glassfish jaxb-runtime_ upgrade. Both _jaxb-core_ jars are unnecessary. New commit removes the non _glassfish jaxb-core_ - thanks! In addition also removed older _jaxb-impl_ dependency as it is the old jaxb runtime which is replaced with the new _org.glassfish jaxb-runtime_. FYI : The following two jiras from another apache project follows what we are doing here: https://issues.apache.org/jira/browse/TIKA-2743,https://issues.apache.org/jira/browse/TIKA-2778. **NOTE**: we are also pulling in an additional jar that we have dependency on, the _javax.activation_ - currently in the base pom file we have the version 1.1.1 dependency, however we have **_also_** the 1.2.0 version (I believe from the jaxb-runtime). Tried updating the base pom.xml file to:
```
<dependency>
<groupId>javax.activation</groupId>
<artifactId>activation</artifactId>
<version>1.2.0</version>
</dependency>
```
however this results in a recon build problem (see attached image). Therefore _**left**_ the _javax.activation_ version at current 1.1.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #2153: HDDS-5068. build errors due to missing JAXB-runtime jar dependency for openjdk 11 se standalone
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #2153:
URL: https://github.com/apache/ozone/pull/2153#discussion_r615860492
##########
File path: hadoop-ozone/dist/src/main/license/bin/LICENSE.txt
##########
@@ -228,12 +228,12 @@ BSD
CDDL
=====================
+ com.sun.istack:istack-commons-runtime
com.sun.jersey:jersey-core
com.sun.jersey:jersey-json
com.sun.jersey:jersey-server
com.sun.jersey:jersey-servlet
com.sun.xml.bind:jaxb-core
Review comment:
I think this one (`com.sun.xml.bind:jaxb-core`) can be removed, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #2153: HDDS-5068. build errors due to missing JAXB-runtime jar dependency for openjdk 11 se standalone
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #2153:
URL: https://github.com/apache/ozone/pull/2153#discussion_r615860492
##########
File path: hadoop-ozone/dist/src/main/license/bin/LICENSE.txt
##########
@@ -228,12 +228,12 @@ BSD
CDDL
=====================
+ com.sun.istack:istack-commons-runtime
com.sun.jersey:jersey-core
com.sun.jersey:jersey-json
com.sun.jersey:jersey-server
com.sun.jersey:jersey-servlet
com.sun.xml.bind:jaxb-core
Review comment:
I think this one can be removed, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] neils-dev edited a comment on pull request #2153: HDDS-5068. build errors due to missing JAXB-runtime jar dependency for openjdk 11 se standalone
Posted by GitBox <gi...@apache.org>.
neils-dev edited a comment on pull request #2153:
URL: https://github.com/apache/ozone/pull/2153#issuecomment-819956555
Thanks **@adoroszlai** for comments on classpath jars resulting from pom build file changes for _jaxb_ upgrade. Yes, unintentionally included is the _org.glassfish jaxb-core_. Apparently it is pulled in from the _org.glassfish jaxb-runtime_ upgrade. Both _jaxb-core_ jars are unnecessary. New commit removes the non _glassfish jaxb-core_ - thanks! In addition also removed older _jaxb-impl_ dependency as it is the old jaxb runtime which is replaced with the new _org.glassfish jaxb-runtime_. FYI : The following two jiras from another apache project follows what we are doing here: https://issues.apache.org/jira/browse/TIKA-2743, https://issues.apache.org/jira/browse/TIKA-2778. **NOTE**: we are also pulling in an additional jar that we have dependency on, the _javax.activation_ - currently in the base pom file we have the version 1.1.1 dependency, however we have **_also_** the 1.2.0 version (I believe from the jaxb-runtime). Tried updating the base pom.xml file to:
```
<dependency>
<groupId>javax.activation</groupId>
<artifactId>activation</artifactId>
<version>1.2.0</version>
</dependency>
```
however this results in a recon build problem (see attached image). Therefore _**left**_ the _javax.activation_ version at current 1.1.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org