You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2018/10/06 09:28:19 UTC
[3/4] groovy git commit: Trivial refactoring: extract method
`initPhaseOperations`
Trivial refactoring: extract method `initPhaseOperations`
(cherry picked from commit 30c11c80c112c78760b23cf2b0f3e54cd5df1a0a)
Project: http://git-wip-us.apache.org/repos/asf/groovy/repo
Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/d604b3c6
Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/d604b3c6
Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/d604b3c6
Branch: refs/heads/GROOVY_2_5_X
Commit: d604b3c68bc50d736777d37882343a6d505ba060
Parents: 1bc1a0c
Author: Daniel Sun <su...@apache.org>
Authored: Sat Oct 6 16:39:51 2018 +0800
Committer: Daniel Sun <su...@apache.org>
Committed: Sat Oct 6 17:27:04 2018 +0800
----------------------------------------------------------------------
.../codehaus/groovy/control/CompilationUnit.java | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/groovy/blob/d604b3c6/src/main/java/org/codehaus/groovy/control/CompilationUnit.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/codehaus/groovy/control/CompilationUnit.java b/src/main/java/org/codehaus/groovy/control/CompilationUnit.java
index 011d4f6..0b14860 100644
--- a/src/main/java/org/codehaus/groovy/control/CompilationUnit.java
+++ b/src/main/java/org/codehaus/groovy/control/CompilationUnit.java
@@ -175,12 +175,7 @@ public class CompilationUnit extends ProcessingUnit {
this.staticImportVisitor = new StaticImportVisitor();
this.optimizer = new OptimizerVisitor(this);
- phaseOperations = new LinkedList[Phases.ALL + 1];
- newPhaseOperations = new LinkedList[Phases.ALL + 1];
- for (int i = 0; i < phaseOperations.length; i++) {
- phaseOperations[i] = new LinkedList();
- newPhaseOperations[i] = new LinkedList();
- }
+ initPhaseOperations();
addPhaseOperation(new SourceUnitOperation() {
public void call(SourceUnit source) throws CompilationFailedException {
source.parse();
@@ -274,6 +269,16 @@ public class CompilationUnit extends ProcessingUnit {
this.classNodeResolver = new ClassNodeResolver();
}
+ private void initPhaseOperations() {
+ int cnt = Phases.ALL + 1;
+ phaseOperations = new LinkedList[cnt];
+ newPhaseOperations = new LinkedList[cnt];
+ for (int i = 0; i < phaseOperations.length; i++) {
+ phaseOperations[i] = new LinkedList();
+ newPhaseOperations[i] = new LinkedList();
+ }
+ }
+
private void applyCompilationCustomizers(CompilerConfiguration configuration) {
// apply configuration customizers if any
if (configuration != null) {