You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ossie.apache.org by "averms (via GitHub)" <gi...@apache.org> on 2026/08/02 22:03:41 UTC
[PR] add pytest and types-pyyaml dev deps to Python package [ossie]
averms opened a new pull request, #295:
URL: https://github.com/apache/ossie/pull/295
The former is needed to run tests and the latter is needed for type checking with mypy.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
## Summary
<!-- Describe what this PR does and why. -->
## Related Issues
<!-- Link any related GitHub issues: Closes #123, Fixes #456 -->
## Checklist
### Tests
- [x] All existing tests pass (`pytest` / CI green)
- [x] New functionality is covered by tests
### Compliance
- [x] ASF license headers are present on all new source files
- [ ] No third-party dependencies are added without PMC/IPMC approval
I guess a third-party dependency was added, https://pypi.org/project/types-PyYAML/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add pytest and types-pyyaml dev deps to Python package [ossie]
Posted by "averms (via GitHub)" <gi...@apache.org>.
averms commented on PR #295:
URL: https://github.com/apache/ossie/pull/295#issuecomment-5561273579
> Hello @averms ,
>
> So this should be fix by https://github.com/apache/ossie/pull/254/changes#diff-1a45bd938160f7761769e7b6fbc819d1cc7f84ce37f1a6a23ef83cc4e214abc8 that I raised a while ago.
>
> @jbonofre mind take a look?
>
> Thanks, Yong
Great, that looks much more thorough than mine. It doesn't include the mypy-driven change but I'll go ahead and close this one and open static typing changes as a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add pytest and types-pyyaml dev deps to Python package [ossie]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #295:
URL: https://github.com/apache/ossie/pull/295#discussion_r3700416834
##########
python/pyproject.toml:
##########
@@ -40,6 +40,12 @@ dependencies = [
homepage = "https://ossie.apache.org/"
repository = "https://github.com/apache/ossie/"
+[dependency-groups]
+dev = [
+ "pytest>=9.1.1",
+ "types-pyyaml>=6.0.12.20260724",
+]
Review Comment:
`uv sync` (as referenced in python/README.md) installs only the default dependency groups; this package currently doesn’t set `tool.uv.default-groups`, so the new `dev` group (and therefore `pytest`) won’t be installed unless contributors remember to pass `--group dev`. Align with other packages in this repo by making `dev` a default group (or update the docs accordingly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add pytest and types-pyyaml dev deps to Python package [ossie]
Posted by "averms (via GitHub)" <gi...@apache.org>.
averms closed pull request #295: add pytest and types-pyyaml dev deps to Python package
URL: https://github.com/apache/ossie/pull/295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add pytest and types-pyyaml dev deps to Python package [ossie]
Posted by "averms (via GitHub)" <gi...@apache.org>.
averms commented on code in PR #295:
URL: https://github.com/apache/ossie/pull/295#discussion_r3700419874
##########
python/pyproject.toml:
##########
@@ -40,6 +40,12 @@ dependencies = [
homepage = "https://ossie.apache.org/"
repository = "https://github.com/apache/ossie/"
+[dependency-groups]
+dev = [
+ "pytest>=9.1.1",
+ "types-pyyaml>=6.0.12.20260724",
+]
Review Comment:
i think this is incorrect. `uv sync` for me _does_ install group dev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add pytest and types-pyyaml dev deps to Python package [ossie]
Posted by "kunaljubce (via GitHub)" <gi...@apache.org>.
kunaljubce commented on code in PR #295:
URL: https://github.com/apache/ossie/pull/295#discussion_r3705864248
##########
python/pyproject.toml:
##########
@@ -40,6 +40,12 @@ dependencies = [
homepage = "https://ossie.apache.org/"
repository = "https://github.com/apache/ossie/"
+[dependency-groups]
+dev = [
+ "pytest>=9.1.1",
+ "types-pyyaml>=6.0.12.20260724",
+]
Review Comment:
Yep, verified that `uv sync` works with a fresh setup:
```bash
→ uv sync
Using CPython 3.14.3
Creating virtual environment at: .venv
Resolved 14 packages in 15ms
Built apache-ossie @ file:///Users/81045729/Documents/constant_variables/ossie/python
Prepared 2 packages in 893ms
Installed 13 packages in 32ms
+ annotated-types==0.7.0
+ apache-ossie==0.2.0.dev0 (from file:///Users/81045729/Documents/constant_variables/ossie/python)
+ iniconfig==2.3.0
+ packaging==26.2
+ pluggy==1.6.0
+ pydantic==2.13.4
+ pydantic-core==2.46.4
+ pygments==2.20.0
+ pytest==9.1.1
+ pyyaml==6.0.3
+ types-pyyaml==6.0.12.20260724
+ typing-extensions==4.16.0
+ typing-inspection==0.4.2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add pytest and types-pyyaml dev deps to Python package [ossie]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on PR #295:
URL: https://github.com/apache/ossie/pull/295#issuecomment-5557764638
Hello @averms ,
So this should be fix by https://github.com/apache/ossie/pull/254/changes#diff-1a45bd938160f7761769e7b6fbc819d1cc7f84ce37f1a6a23ef83cc4e214abc8 that I raised a while ago.
@jbonofre mind take a look?
Thanks,
Yong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org