You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/02/07 12:02:47 UTC
[GitHub] [cloudstack] Spaceman1984 opened a new pull request #3873: Fixed
root volume resize from ui
Spaceman1984 opened a new pull request #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873
## Description
<!--- Describe your changes in detail -->
This PR fixes the volume resize action for a root volume from the UI.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
Fixes: #3860
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
This has been tested by creating an instance and resizing the root volume. The root volume size is then verified in storage metrics.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-585081883
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-584521877
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-584134799
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 edited a comment on issue #3873: Fixed
root volume resize from ui
Posted by GitBox <gi...@apache.org>.
Spaceman1984 edited a comment on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-584027695
> @Spaceman1984
> I have tested it ,it works.
>
> however, I think we can use the following change on line 1578
>
> ```
> if (selectedDiskOfferingObj == null || selectedDiskOfferingObj.iscustomized == true) {
> ```
>
> the change on line 1597-1601 are not needed then.
>
> the change on line 1584 are needed.
@weizhouapache
I agree with all, accept, I think line 1601 can be removed, but we need to keep line 1597-1600 - it's an error message about not allowing a smaller volume size. - Ok, I think I know what you mean. If I revert that change, it would be the same, except for the initial newSize variable that didn't exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-583673061
<b>Trillian test result (tid-933)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36730 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3873-t933-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 215.15 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 213.78 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 317.99 | test_privategw_acl.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-584531320
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-583367517
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3873: Fixed root volume
resize from ui
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-585081699
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-584027695
> @Spaceman1984
> I have tested it ,it works.
>
> however, I think we can use the following change on line 1578
>
> ```
> if (selectedDiskOfferingObj == null || selectedDiskOfferingObj.iscustomized == true) {
> ```
>
> the change on line 1597-1601 are not needed then.
>
> the change on line 1584 are needed.
@weizhouapache
I agree with all, accept, I think line 1601 can be removed, but we need to keep line 1597-1600 - it's an error message about not allowing a smaller volume size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-584024163
@Spaceman1984
I have tested it ,it works.
however, I think we can use the following change on line 1578
```
if (selectedDiskOfferingObj == null || selectedDiskOfferingObj.iscustomized == true) {
```
the change on line 1597-1601 are not needed then.
the change on line 1584 are needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-584094967
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3873: Fixed root volume
resize from ui
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-583367457
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-584036597
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-584538154
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-801
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-584521721
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-583373429
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-788
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 edited a comment on issue #3873: Fixed
root volume resize from ui
Posted by GitBox <gi...@apache.org>.
Spaceman1984 edited a comment on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-584027695
> @Spaceman1984
> I have tested it ,it works.
>
> however, I think we can use the following change on line 1578
>
> ```
> if (selectedDiskOfferingObj == null || selectedDiskOfferingObj.iscustomized == true) {
> ```
>
> the change on line 1597-1601 are not needed then.
>
> the change on line 1584 are needed.
@weizhouapache
I agree with all, accept, I think line 1601 can be removed, but we need to keep line 1597-1600 - it's an error message about not allowing a smaller volume size. - Ok, I think I know what you mean. If I revert that change, it would be the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-585091499
I guess we could merge this one as it does not require marvin tests (UI fix).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-585130105
Packaging result: ✖centos6 ✖centos7 ✔debian. JID-823
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request
#3873: Fixed root volume resize from ui
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#discussion_r377490738
##########
File path: ui/scripts/storage.js
##########
@@ -1575,13 +1575,13 @@
if (newDiskOffering != null && newDiskOffering.length > 0) {
array1.push("&diskofferingid=" + encodeURIComponent(newDiskOffering));
}
- if (selectedDiskOfferingObj.iscustomized == true) {
+ if (selectedDiskOfferingObj == null || selectedDiskOfferingObj.iscustomized == true) {
Review comment:
I have changed the logic to check the volume type instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-583395509
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-583395704
@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-584029503
All good @weizhouapache, I will make those changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 edited a comment on issue #3873: Fixed
root volume resize from ui
Posted by GitBox <gi...@apache.org>.
Spaceman1984 edited a comment on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-584027695
> @Spaceman1984
> I have tested it ,it works.
>
> however, I think we can use the following change on line 1578
>
> ```
> if (selectedDiskOfferingObj == null || selectedDiskOfferingObj.iscustomized == true) {
> ```
>
> the change on line 1597-1601 are not needed then.
>
> the change on line 1584 are needed.
@weizhouapache
I agree with all, accept, I think line 1601 can be removed, but we need to keep line 1597-1600 - it's an error message about not allowing a smaller volume size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-584135103
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-584014097
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-584527451
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-800
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-584531566
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request
#3873: Fixed root volume resize from ui
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#discussion_r377482502
##########
File path: ui/scripts/storage.js
##########
@@ -1575,13 +1575,13 @@
if (newDiskOffering != null && newDiskOffering.length > 0) {
array1.push("&diskofferingid=" + encodeURIComponent(newDiskOffering));
}
- if (selectedDiskOfferingObj.iscustomized == true) {
+ if (selectedDiskOfferingObj == null || selectedDiskOfferingObj.iscustomized == true) {
Review comment:
aren't we making an assumption here about the reason the offering is missing? We only want to allow it if it is missing because it is a root-disk. It looks like we are allowing some client side hacking; set the `selectedDiskOfferingObj` to `null` and you are good to go. (i didn't check the API)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3873: Fixed root
volume resize from ui
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-584184673
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-797
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services