You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by yi...@apache.org on 2018/12/19 10:36:28 UTC

[royale-asjs] 01/04: Match DragEvent.clientX with MouseEvent.clientX

This is an automated email from the ASF dual-hosted git repository.

yishayw pushed a commit to branch refactor_sensitive_bead
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git

commit 05598c451f860108e2d52130fe15f98464d8c240
Author: DESKTOP-RH4S838\Yishay <yi...@hotmail.com>
AuthorDate: Wed Dec 19 12:31:47 2018 +0200

    Match DragEvent.clientX with MouseEvent.clientX
---
 .../src/main/royale/org/apache/royale/events/DragEvent.as    | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/frameworks/projects/DragDrop/src/main/royale/org/apache/royale/events/DragEvent.as b/frameworks/projects/DragDrop/src/main/royale/org/apache/royale/events/DragEvent.as
index 8c1023b..208fe57 100644
--- a/frameworks/projects/DragDrop/src/main/royale/org/apache/royale/events/DragEvent.as
+++ b/frameworks/projects/DragDrop/src/main/royale/org/apache/royale/events/DragEvent.as
@@ -374,10 +374,8 @@ package org.apache.royale.events
                 de.delta = event.delta;
                 de.relatedObject = event.target as InteractiveObject;
 				
-				var localPoint:Point = new Point(event.screenX, event.screenY);
-				var clientPoint:Point = PointUtils.localToGlobal(localPoint, event.target);
-				de.clientX = clientPoint.x;
-				de.clientY = clientPoint.y;
+				de.clientX = event.clientX;
+				de.clientY = event.clientY;
 				
                 return de;                    
             }
@@ -390,10 +388,8 @@ package org.apache.royale.events
 				de.shiftKey = event.shiftKey;
 				de.relatedObject = event.target;
 				
-				var localPoint:Point = new Point(event.screenX, event.screenY);
-				var clientPoint:Point = PointUtils.localToGlobal(localPoint, event.target);
-				de.clientX = clientPoint.x;
-				de.clientY = clientPoint.y;
+				de.clientX = event.clientX;
+				de.clientY = event.clientY;
 				
 				return de;
             }


RE: [royale-asjs] 01/04: Match DragEvent.clientX with MouseEvent.clientX

Posted by Yishay Weiss <yi...@hotmail.com>.
This modifies Peter’s code which was committed with the comment saying it was ‘preliminary’. If there are no objections I’ll merge it by tomorrow.



________________________________
From: yishayw@apache.org <yi...@apache.org>
Sent: Wednesday, December 19, 2018 12:36:28 PM
To: commits@royale.apache.org
Subject: [royale-asjs] 01/04: Match DragEvent.clientX with MouseEvent.clientX

This is an automated email from the ASF dual-hosted git repository.

yishayw pushed a commit to branch refactor_sensitive_bead
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git

commit 05598c451f860108e2d52130fe15f98464d8c240
Author: DESKTOP-RH4S838\Yishay <yi...@hotmail.com>
AuthorDate: Wed Dec 19 12:31:47 2018 +0200

    Match DragEvent.clientX with MouseEvent.clientX
---
 .../src/main/royale/org/apache/royale/events/DragEvent.as    | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/frameworks/projects/DragDrop/src/main/royale/org/apache/royale/events/DragEvent.as b/frameworks/projects/DragDrop/src/main/royale/org/apache/royale/events/DragEvent.as
index 8c1023b..208fe57 100644
--- a/frameworks/projects/DragDrop/src/main/royale/org/apache/royale/events/DragEvent.as
+++ b/frameworks/projects/DragDrop/src/main/royale/org/apache/royale/events/DragEvent.as
@@ -374,10 +374,8 @@ package org.apache.royale.events
                 de.delta = event.delta;
                 de.relatedObject = event.target as InteractiveObject;

-                               var localPoint:Point = new Point(event.screenX, event.screenY);
-                               var clientPoint:Point = PointUtils.localToGlobal(localPoint, event.target);
-                               de.clientX = clientPoint.x;
-                               de.clientY = clientPoint.y;
+                               de.clientX = event.clientX;
+                               de.clientY = event.clientY;

                 return de;
             }
@@ -390,10 +388,8 @@ package org.apache.royale.events
                                 de.shiftKey = event.shiftKey;
                                 de.relatedObject = event.target;

-                               var localPoint:Point = new Point(event.screenX, event.screenY);
-                               var clientPoint:Point = PointUtils.localToGlobal(localPoint, event.target);
-                               de.clientX = clientPoint.x;
-                               de.clientY = clientPoint.y;
+                               de.clientX = event.clientX;
+                               de.clientY = event.clientY;

                                 return de;
             }