[GitHub] [iceberg] bryanck commented on a diff in pull request #7976: Core: Extend ResolvingFileIO to support BulkOperations

["bryanck (via GitHub)" <gi...@apache.org>]

bryanck commented on code in PR #7976:
URL: https://github.com/apache/iceberg/pull/7976#discussion_r1284646569


##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -83,6 +86,29 @@ public void deleteFile(String location) {
     io(location).deleteFile(location);
   }
 
+  @Override
+  public void deleteFiles(Iterable<String> pathsToDelete) throws BulkDeletionFailureException {
+    Map<FileIO, List<String>> pathByFileIO =
+        StreamSupport.stream(pathsToDelete.spliterator(), false)

Review Comment:
   I don't feel it is a good idea to load all files into memory first. There is another PR with similar intent: https://github.com/apache/iceberg/pull/8169, did you want to give feedback on that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org