You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by mp...@apache.org on 2017/08/29 18:46:21 UTC
kudu git commit: consensus_peers: don't log tablet copy attempts that
were throttled
Repository: kudu
Updated Branches:
refs/heads/master 2247931fd -> 2d6a2ac7f
consensus_peers: don't log tablet copy attempts that were throttled
When a tserver with ~6k tablets was killed in a 9 node cluster, another node
started logging ~800 lines of throttled tablet copy messages per second.
This isn't useful and fills up disks.
Change-Id: Ib1c7717847c73870110376d0e7052f0118cb0200
Reviewed-on: http://gerrit.cloudera.org:8080/7868
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Hao Hao <ha...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Mike Percy <mp...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/2d6a2ac7
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/2d6a2ac7
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/2d6a2ac7
Branch: refs/heads/master
Commit: 2d6a2ac7f1255fd6084a42244174eb94d55df57e
Parents: 2247931
Author: Adar Dembo <ad...@cloudera.com>
Authored: Mon Aug 28 17:44:27 2017 -0700
Committer: Mike Percy <mp...@apache.org>
Committed: Tue Aug 29 18:45:25 2017 +0000
----------------------------------------------------------------------
src/kudu/consensus/consensus_peers.cc | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/2d6a2ac7/src/kudu/consensus/consensus_peers.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/consensus_peers.cc b/src/kudu/consensus/consensus_peers.cc
index 26f6ab4..546f46d 100644
--- a/src/kudu/consensus/consensus_peers.cc
+++ b/src/kudu/consensus/consensus_peers.cc
@@ -389,7 +389,10 @@ void Peer::ProcessTabletCopyResponse() {
if (success) {
lock.unlock();
queue_->NotifyPeerIsResponsive(peer_pb_.permanent_uuid());
- } else {
+ } else if (!tc_response_.has_error() ||
+ tc_response_.error().code() != TabletServerErrorPB::TabletServerErrorPB::THROTTLED) {
+ // THROTTLED is a common response after a tserver with many replicas fails;
+ // logging it would generate a great deal of log spam.
LOG_WITH_PREFIX_UNLOCKED(WARNING) << "Unable to begin Tablet Copy on peer: "
<< (controller_.status().ok() ?
SecureShortDebugString(tc_response_) :