You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2025/10/03 03:47:19 UTC
[PR] macos-13 is deprecated [arrow-java]
kevinjqliu opened a new pull request, #868:
URL: https://github.com/apache/arrow-java/pull/868
## What's Changed
https://github.blog/changelog/2025-09-19-github-actions-macos-13-runner-image-is-closing-down/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] macos-13 is deprecated [arrow-java]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #868:
URL: https://github.com/apache/arrow-java/pull/868#discussion_r2400717270
##########
.github/workflows/rc.yml:
##########
@@ -168,7 +168,7 @@ jobs:
fail-fast: false
matrix:
platform:
- - { runs_on: macos-13, arch: "x86_64"}
+ - { runs_on: macos-latest, arch: "aarch_64"}
Review Comment:
We can remove this pattern entirely.
We just drop support for Intel macOS.
##########
.github/workflows/rc.yml:
##########
@@ -233,10 +229,10 @@ jobs:
# tries to replace /usr/local/bin/2to3 and so on and causes
# a conflict error.
brew update
- for python_package in $(brew list | grep python@ | sort -r); do
+ for python_package in $(brew list | grep python@); do
brew install --overwrite ${python_package}
done
- brew install --overwrite python3
+ brew install --overwrite python
Review Comment:
We can remove this.
##########
.github/workflows/rc.yml:
##########
Review Comment:
We may be able to remove this entirely now.
##########
.github/workflows/rc.yml:
##########
@@ -233,10 +229,10 @@ jobs:
# tries to replace /usr/local/bin/2to3 and so on and causes
# a conflict error.
brew update
- for python_package in $(brew list | grep python@ | sort -r); do
+ for python_package in $(brew list | grep python@); do
brew install --overwrite ${python_package}
done
- brew install --overwrite python3
+ brew install --overwrite python
if [ "$(uname -m)" = "arm64" ]; then
Review Comment:
We can remove this `if`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] macos-13 is deprecated [arrow-java]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #868:
URL: https://github.com/apache/arrow-java/pull/868#discussion_r2404182993
##########
.github/workflows/rc.yml:
##########
@@ -168,7 +168,7 @@ jobs:
fail-fast: false
matrix:
platform:
- - { runs_on: macos-13, arch: "x86_64"}
+ - { runs_on: macos-latest, arch: "aarch_64"}
Review Comment:
> We just drop support for Intel macOS.
do you mean the project dropped support for intel macos? so this line should just be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] macos-13 is deprecated [arrow-java]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #868:
URL: https://github.com/apache/arrow-java/pull/868#issuecomment-3368564149
thanks for the review @kou
im trying to keep this pr scoped to the minimum necessary to replace macos-13. seems like macos-15-intel is the direct replacement according to https://docs.github.com/en/actions/reference/runners/github-hosted-runners#standard-github-hosted-runners-for-public-repositories
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] macos-13 is deprecated [arrow-java]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre closed pull request #868: macos-13 is deprecated
URL: https://github.com/apache/arrow-java/pull/868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] macos-13 is deprecated [arrow-java]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #868:
URL: https://github.com/apache/arrow-java/pull/868#issuecomment-3388156308
@kevinjqliu it's included already in #865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] macos-13 is deprecated [arrow-java]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #868:
URL: https://github.com/apache/arrow-java/pull/868#discussion_r2404182954
##########
.github/workflows/rc.yml:
##########
@@ -168,7 +168,7 @@ jobs:
fail-fast: false
matrix:
platform:
- - { runs_on: macos-13, arch: "x86_64"}
+ - { runs_on: macos-latest, arch: "aarch_64"}
Review Comment:
i made the change to replace macos-13 with macos-15-intel per https://docs.github.com/en/actions/reference/runners/github-hosted-runners#standard-github-hosted-runners-for-public-repositories
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] macos-13 is deprecated [arrow-java]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #868:
URL: https://github.com/apache/arrow-java/pull/868#discussion_r2404758647
##########
.github/workflows/rc.yml:
##########
@@ -233,10 +229,9 @@ jobs:
# tries to replace /usr/local/bin/2to3 and so on and causes
# a conflict error.
brew update
- for python_package in $(brew list | grep python@ | sort -r); do
+ for python_package in $(brew list | grep python@); do
brew install --overwrite ${python_package}
done
- brew install --overwrite python3
Review Comment:
If we keep Intel macOS support, we should not remove these changes because `macos-15-intel` still uses `/usr/local` as Homebrew prefix: https://github.com/apache/arrow-java/actions/runs/18250044030/job/51963266710?pr=868#step:9:65
```text
To restore the stashed changes to /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core, run:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] macos-13 is deprecated [arrow-java]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #868:
URL: https://github.com/apache/arrow-java/pull/868#discussion_r2408820394
##########
.github/workflows/rc.yml:
##########
@@ -233,10 +229,9 @@ jobs:
# tries to replace /usr/local/bin/2to3 and so on and causes
# a conflict error.
brew update
- for python_package in $(brew list | grep python@ | sort -r); do
+ for python_package in $(brew list | grep python@); do
brew install --overwrite ${python_package}
done
- brew install --overwrite python3
Review Comment:
yea makes sense, good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org