[GitHub] [maven-plugin-tools] gnodet commented on a diff in pull request #167: [MPLUGIN-437] Fixes to the plugin descriptor generation

[GitBox <gi...@apache.org>]

gnodet commented on code in PR #167:
URL: https://github.com/apache/maven-plugin-tools/pull/167#discussion_r1007785543


##########
maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/converter/JavaClassConverterContext.java:
##########
@@ -81,13 +80,6 @@ public JavaClassConverterContext( JavaClass mojoClass, JavaClass declaringClass,
                                       Map<String, MojoAnnotatedClass> mojoAnnotatedClasses,
                                       JavadocLinkGenerator linkGenerator, int lineNumber )
     {
-        if ( !( mojoClass.getJavaClassLibrary() instanceof SourceLibrary )

Review Comment:
   I did remove the fact that the generation will throw an exception, not the fact that it will be used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org