You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Randy Abernethy (JIRA)" <ji...@apache.org> on 2015/03/15 16:41:38 UTC

[jira] [Resolved] (THRIFT-3040) bower.json wrong "main" path

     [ https://issues.apache.org/jira/browse/THRIFT-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Randy Abernethy resolved THRIFT-3040.
-------------------------------------
       Resolution: Fixed
    Fix Version/s: 0.9.3
         Assignee: Randy Abernethy

Committed, thanks for the patch!

Note, our Bower solution is a mess (cloning the entire thrift repo) and may change in the future. Also the src dir thrift.js may end up broken into multiple files, with thrift.js only being available in lib/js/dist after a grunt build. In the mean time this patch is a needed fix.

> bower.json wrong "main" path
> ----------------------------
>
>                 Key: THRIFT-3040
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3040
>             Project: Thrift
>          Issue Type: Bug
>          Components: JavaScript - Library
>    Affects Versions: 0.9.2
>            Reporter: Paul Smith
>            Assignee: Randy Abernethy
>            Priority: Minor
>             Fix For: 0.9.3
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> How to produce:
> bower install thrift -save
> grunt wiredep
> with the current path thrift is not included.
> it has to be changed from
> -  "main": "lib/js/thrift.js",
> to
> +  "main": "lib/js/src/thrift.js",
> Pull request on GitHub: https://github.com/apache/thrift/pull/398



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)