[GitHub] [calcite] snuyanzin commented on a diff in pull request #3240: [CALCITE-5748] Upgrade guava from 31.1-jre to 32.0.0-jre

["snuyanzin (via GitHub)" <gi...@apache.org>]

snuyanzin commented on code in PR #3240:
URL: https://github.com/apache/calcite/pull/3240#discussion_r1215713299


##########
core/src/main/java/org/apache/calcite/runtime/Hook.java:
##########
@@ -159,15 +159,6 @@ public <T> Closeable addThread(final Consumer<T> handler) {
     return () -> removeThread(handler);
   }
 
-  // CHECKSTYLE: IGNORE 1
-  /** @deprecated Use {@link #addThread(Consumer)}. */
-  @SuppressWarnings("Guava")
-  @Deprecated // to be removed before 2.0
-  public <T, R> Closeable addThread(
-      final com.google.common.base.Function<T, R> handler) {
-    return addThread((Consumer<T>) handler::apply);
-  }

Review Comment:
   With guava 32 it starts failing on errorprone checks with `CheckReturnValue`
   Since it is already deprecated with  a comment what to use instead probably it makes sense to remove it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org