You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/28 15:08:37 UTC

[GitHub] [maven] kwin commented on a diff in pull request #843: Move back model version from 5.0 to 4.2 and reactivate modello site generation

kwin commented on code in PR #843:
URL: https://github.com/apache/maven/pull/843#discussion_r1008171140


##########
maven-model/pom.xml:
##########
@@ -79,18 +79,38 @@ under the License.
         <artifactId>modello-plugin-velocity</artifactId>
         <executions>
           <execution>
-            <id>velocity</id>
+            <id>velocity-v3</id>
             <phase>generate-sources</phase>
             <goals>
               <goal>velocity</goal>
             </goals>
             <configuration>
-              <version>4.0.0</version>
+              <version>4.1.0</version>

Review Comment:
   I would still propose we use 4.0.1 and 4.0.2 to be more in line with semantic versioning as IMHO the API does not change at all!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org