You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by necouchman <gi...@git.apache.org> on 2018/02/03 22:48:50 UTC
[GitHub] guacamole-client pull request #243: GUACAMOLE-316: Tweak to handling IE Comp...
GitHub user necouchman opened a pull request:
https://github.com/apache/guacamole-client/pull/243
GUACAMOLE-316: Tweak to handling IE Compatibility Mode
This is a quick tweak suggested by the person who opened -316 in JIRA to correctly preventing Compatibility Mode from kicking in for IE when it is enabled for subnets or certain networks.
Tested with Chrome on Linux and Windows to make sure there were no adverse impacts, there, and then tested on IE11 and Edge in Windows 10. I don't have compatibility mode enabled across my network, so I don't know that it actually resolves the issue, but it doesn't make things worse. Will ping back on the JIRA issue and see if I can get the owner to test it for me - unless someone else can give it a try??
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/necouchman/guacamole-client GUACAMOLE-316
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/guacamole-client/pull/243.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #243
----
commit 8747acfc7f3650750bd89c8259d556675f48dc01
Author: Nick Couchman <vn...@...>
Date: 2018-02-03T22:39:48Z
GUACAMOLE-316: Make sure IE compatibility mode does not impact Guacamole.
----
---
[GitHub] guacamole-client pull request #243: GUACAMOLE-316: Tweak to handling IE Comp...
Posted by necouchman <gi...@git.apache.org>.
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/243#discussion_r165833486
--- Diff: guacamole/src/main/webapp/index.html ---
@@ -19,7 +19,8 @@
-->
<html ng-app="index" ng-controller="indexController">
<head>
- <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
+ <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
+ <meta http-equiv="x-ua-compatible" content="IE=edge"/>
--- End diff --
According to the MSDN page, all lower-case:
https://msdn.microsoft.com/en-us/library/jj676915(v=vs.85).aspx
---
[GitHub] guacamole-client pull request #243: GUACAMOLE-316: Tweak to handling IE Comp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/guacamole-client/pull/243
---
[GitHub] guacamole-client pull request #243: GUACAMOLE-316: Tweak to handling IE Comp...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/243#discussion_r165834069
--- Diff: guacamole/src/main/webapp/index.html ---
@@ -19,7 +19,8 @@
-->
<html ng-app="index" ng-controller="indexController">
<head>
- <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
+ <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
+ <meta http-equiv="x-ua-compatible" content="IE=edge"/>
--- End diff --
Ah, OK.
---
[GitHub] guacamole-client pull request #243: GUACAMOLE-316: Tweak to handling IE Comp...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/243#discussion_r165833126
--- Diff: guacamole/src/main/webapp/index.html ---
@@ -19,7 +19,8 @@
-->
<html ng-app="index" ng-controller="indexController">
<head>
- <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
+ <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
+ <meta http-equiv="x-ua-compatible" content="IE=edge"/>
--- End diff --
Is it "x-ua-compatible" or "X-UA-Compatible"?
---