You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Sebastian Ortega (JIRA)" <ji...@apache.org> on 2012/06/20 09:17:42 UTC
[jira] [Created] (AVRO-1119) NettyServer support for SSL
Sebastian Ortega created AVRO-1119:
--------------------------------------
Summary: NettyServer support for SSL
Key: AVRO-1119
URL: https://issues.apache.org/jira/browse/AVRO-1119
Project: Avro
Issue Type: Bug
Components: java
Affects Versions: 1.7.0, 1.6.3
Reporter: Sebastian Ortega
When trying to use NettyServer with SSL support I have problems despite [AVRO-898] has been accepted. If I am not wrong, the SSLHandler should be added to the worker pipelines but you cannot do that with the current interface.
I've prepared a patch of a different approach. I've added a new constructor of type ChannelPipelineFactory used to initialize the worker pipeline instead of calling Channels.pipeline() directly. Please see the attached path.
If I'm wrong, I wil be very grateful to know how to solve it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-1119) NettyServer support for SSL
Posted by "Sebastian Ortega (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406325#comment-13406325 ]
Sebastian Ortega commented on AVRO-1119:
----------------------------------------
I hope everything is OK now.
Thank you!
> NettyServer support for SSL
> ---------------------------
>
> Key: AVRO-1119
> URL: https://issues.apache.org/jira/browse/AVRO-1119
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.6.3, 1.7.0
> Reporter: Sebastian Ortega
> Fix For: 1.7.1
>
> Attachments: 0001-Add-NettyServer-constructor-for-custom-pipelines-with-test.patch, servercert.p12
>
>
> When trying to use NettyServer with SSL support I have problems despite [AVRO-898] has been accepted. If I am not wrong, the SSLHandler should be added to the worker pipelines but you cannot do that with the current interface.
> I've prepared a patch of a different approach. I've added a new constructor of type ChannelPipelineFactory used to initialize the worker pipeline instead of calling Channels.pipeline() directly. Please see the attached path.
> If I'm wrong, I wil be very grateful to know how to solve it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-1119) NettyServer support for SSL
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405239#comment-13405239 ]
Doug Cutting commented on AVRO-1119:
------------------------------------
The patch looks reasonable to me (a non-Netty expert) and existing tests pass with it. However it is an incompatible API change for anyone who was using the old constructor. So unless we're convinced that the prior version was totally unusable we should continue to support it as well. Also, can you please add a test that uses the new constructor? Thanks!
> NettyServer support for SSL
> ---------------------------
>
> Key: AVRO-1119
> URL: https://issues.apache.org/jira/browse/AVRO-1119
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.6.3, 1.7.0
> Reporter: Sebastian Ortega
> Fix For: 1.7.1
>
> Attachments: 0001-Add-NettyServer-constructor-for-custom-pipelines.patch
>
>
> When trying to use NettyServer with SSL support I have problems despite [AVRO-898] has been accepted. If I am not wrong, the SSLHandler should be added to the worker pipelines but you cannot do that with the current interface.
> I've prepared a patch of a different approach. I've added a new constructor of type ChannelPipelineFactory used to initialize the worker pipeline instead of calling Channels.pipeline() directly. Please see the attached path.
> If I'm wrong, I wil be very grateful to know how to solve it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1119) NettyServer support for SSL
Posted by "Sebastian Ortega (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Ortega updated AVRO-1119:
-----------------------------------
Attachment: 0001-Add-NettyServer-constructor-for-custom-pipelines-with-test.patch
Updated patch
> NettyServer support for SSL
> ---------------------------
>
> Key: AVRO-1119
> URL: https://issues.apache.org/jira/browse/AVRO-1119
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.6.3, 1.7.0
> Reporter: Sebastian Ortega
> Fix For: 1.7.1
>
> Attachments: 0001-Add-NettyServer-constructor-for-custom-pipelines-with-test.patch, servercert.p12
>
>
> When trying to use NettyServer with SSL support I have problems despite [AVRO-898] has been accepted. If I am not wrong, the SSLHandler should be added to the worker pipelines but you cannot do that with the current interface.
> I've prepared a patch of a different approach. I've added a new constructor of type ChannelPipelineFactory used to initialize the worker pipeline instead of calling Channels.pipeline() directly. Please see the attached path.
> If I'm wrong, I wil be very grateful to know how to solve it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-1119) NettyServer support for SSL
Posted by "Sebastian Ortega (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405700#comment-13405700 ]
Sebastian Ortega commented on AVRO-1119:
----------------------------------------
Well, it is not an incompatible API change since the old constructor already exists and calls the new one. Indeed, the tests are exercising both constructors but I can add some additional test case if necessary.
Thanks for you attention Doug
> NettyServer support for SSL
> ---------------------------
>
> Key: AVRO-1119
> URL: https://issues.apache.org/jira/browse/AVRO-1119
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.6.3, 1.7.0
> Reporter: Sebastian Ortega
> Fix For: 1.7.1
>
> Attachments: 0001-Add-NettyServer-constructor-for-custom-pipelines.patch
>
>
> When trying to use NettyServer with SSL support I have problems despite [AVRO-898] has been accepted. If I am not wrong, the SSLHandler should be added to the worker pipelines but you cannot do that with the current interface.
> I've prepared a patch of a different approach. I've added a new constructor of type ChannelPipelineFactory used to initialize the worker pipeline instead of calling Channels.pipeline() directly. Please see the attached path.
> If I'm wrong, I wil be very grateful to know how to solve it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1119) NettyServer support for SSL
Posted by "Sebastian Ortega (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Ortega updated AVRO-1119:
-----------------------------------
Attachment: servercert.p12
Sample self-signed certificate for the unit test.
> NettyServer support for SSL
> ---------------------------
>
> Key: AVRO-1119
> URL: https://issues.apache.org/jira/browse/AVRO-1119
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.6.3, 1.7.0
> Reporter: Sebastian Ortega
> Fix For: 1.7.1
>
> Attachments: 0001-Add-NettyServer-constructor-for-custom-pipelines-with-test.patch, servercert.p12
>
>
> When trying to use NettyServer with SSL support I have problems despite [AVRO-898] has been accepted. If I am not wrong, the SSLHandler should be added to the worker pipelines but you cannot do that with the current interface.
> I've prepared a patch of a different approach. I've added a new constructor of type ChannelPipelineFactory used to initialize the worker pipeline instead of calling Channels.pipeline() directly. Please see the attached path.
> If I'm wrong, I wil be very grateful to know how to solve it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1119) NettyServer support for SSL
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-1119:
-------------------------------
Resolution: Fixed
Assignee: Sebastian Ortega
Status: Resolved (was: Patch Available)
I committed this. Thanks, Sebastian!
> NettyServer support for SSL
> ---------------------------
>
> Key: AVRO-1119
> URL: https://issues.apache.org/jira/browse/AVRO-1119
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.6.3, 1.7.0
> Reporter: Sebastian Ortega
> Assignee: Sebastian Ortega
> Fix For: 1.7.1
>
> Attachments: 0001-Add-NettyServer-constructor-for-custom-pipelines-with-test.patch, servercert.p12
>
>
> When trying to use NettyServer with SSL support I have problems despite [AVRO-898] has been accepted. If I am not wrong, the SSLHandler should be added to the worker pipelines but you cannot do that with the current interface.
> I've prepared a patch of a different approach. I've added a new constructor of type ChannelPipelineFactory used to initialize the worker pipeline instead of calling Channels.pipeline() directly. Please see the attached path.
> If I'm wrong, I wil be very grateful to know how to solve it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1119) NettyServer support for SSL
Posted by "Sebastian Ortega (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Ortega updated AVRO-1119:
-----------------------------------
Attachment: (was: 0001-Add-NettyServer-constructor-for-custom-pipelines-with-test.patch)
> NettyServer support for SSL
> ---------------------------
>
> Key: AVRO-1119
> URL: https://issues.apache.org/jira/browse/AVRO-1119
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.6.3, 1.7.0
> Reporter: Sebastian Ortega
> Fix For: 1.7.1
>
> Attachments: 0001-Add-NettyServer-constructor-for-custom-pipelines-with-test.patch, servercert.p12
>
>
> When trying to use NettyServer with SSL support I have problems despite [AVRO-898] has been accepted. If I am not wrong, the SSLHandler should be added to the worker pipelines but you cannot do that with the current interface.
> I've prepared a patch of a different approach. I've added a new constructor of type ChannelPipelineFactory used to initialize the worker pipeline instead of calling Channels.pipeline() directly. Please see the attached path.
> If I'm wrong, I wil be very grateful to know how to solve it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1119) NettyServer support for SSL
Posted by "Sebastian Ortega (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Ortega updated AVRO-1119:
-----------------------------------
Attachment: 0001-Add-NettyServer-constructor-for-custom-pipelines.patch
git diff patch
> NettyServer support for SSL
> ---------------------------
>
> Key: AVRO-1119
> URL: https://issues.apache.org/jira/browse/AVRO-1119
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.6.3, 1.7.0
> Reporter: Sebastian Ortega
> Fix For: 1.7.1
>
> Attachments: 0001-Add-NettyServer-constructor-for-custom-pipelines.patch
>
>
> When trying to use NettyServer with SSL support I have problems despite [AVRO-898] has been accepted. If I am not wrong, the SSLHandler should be added to the worker pipelines but you cannot do that with the current interface.
> I've prepared a patch of a different approach. I've added a new constructor of type ChannelPipelineFactory used to initialize the worker pipeline instead of calling Channels.pipeline() directly. Please see the attached path.
> If I'm wrong, I wil be very grateful to know how to solve it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1119) NettyServer support for SSL
Posted by "Sebastian Ortega (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Ortega updated AVRO-1119:
-----------------------------------
Fix Version/s: 1.7.1
Status: Patch Available (was: Open)
> NettyServer support for SSL
> ---------------------------
>
> Key: AVRO-1119
> URL: https://issues.apache.org/jira/browse/AVRO-1119
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.7.0, 1.6.3
> Reporter: Sebastian Ortega
> Fix For: 1.7.1
>
> Attachments: 0001-Add-NettyServer-constructor-for-custom-pipelines.patch
>
>
> When trying to use NettyServer with SSL support I have problems despite [AVRO-898] has been accepted. If I am not wrong, the SSLHandler should be added to the worker pipelines but you cannot do that with the current interface.
> I've prepared a patch of a different approach. I've added a new constructor of type ChannelPipelineFactory used to initialize the worker pipeline instead of calling Channels.pipeline() directly. Please see the attached path.
> If I'm wrong, I wil be very grateful to know how to solve it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-1119) NettyServer support for SSL
Posted by "Sebastian Ortega (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405816#comment-13405816 ]
Sebastian Ortega commented on AVRO-1119:
----------------------------------------
I've updated the patch with a SSL test case just in case.
> NettyServer support for SSL
> ---------------------------
>
> Key: AVRO-1119
> URL: https://issues.apache.org/jira/browse/AVRO-1119
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.6.3, 1.7.0
> Reporter: Sebastian Ortega
> Fix For: 1.7.1
>
> Attachments: 0001-Add-NettyServer-constructor-for-custom-pipelines-with-test.patch
>
>
> When trying to use NettyServer with SSL support I have problems despite [AVRO-898] has been accepted. If I am not wrong, the SSLHandler should be added to the worker pipelines but you cannot do that with the current interface.
> I've prepared a patch of a different approach. I've added a new constructor of type ChannelPipelineFactory used to initialize the worker pipeline instead of calling Channels.pipeline() directly. Please see the attached path.
> If I'm wrong, I wil be very grateful to know how to solve it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-1119) NettyServer support for SSL
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406056#comment-13406056 ]
Doug Cutting commented on AVRO-1119:
------------------------------------
Patch looks good but servercert.p12 is missing. Can you please attach that too?
Also, was the change to pom.xml intentional?
Thanks!
> NettyServer support for SSL
> ---------------------------
>
> Key: AVRO-1119
> URL: https://issues.apache.org/jira/browse/AVRO-1119
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.6.3, 1.7.0
> Reporter: Sebastian Ortega
> Fix For: 1.7.1
>
> Attachments: 0001-Add-NettyServer-constructor-for-custom-pipelines-with-test.patch
>
>
> When trying to use NettyServer with SSL support I have problems despite [AVRO-898] has been accepted. If I am not wrong, the SSLHandler should be added to the worker pipelines but you cannot do that with the current interface.
> I've prepared a patch of a different approach. I've added a new constructor of type ChannelPipelineFactory used to initialize the worker pipeline instead of calling Channels.pipeline() directly. Please see the attached path.
> If I'm wrong, I wil be very grateful to know how to solve it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1119) NettyServer support for SSL
Posted by "Sebastian Ortega (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Ortega updated AVRO-1119:
-----------------------------------
Attachment: 0001-Add-NettyServer-constructor-for-custom-pipelines-with-test.patch
Added junit test for SSL scenario.
> NettyServer support for SSL
> ---------------------------
>
> Key: AVRO-1119
> URL: https://issues.apache.org/jira/browse/AVRO-1119
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.6.3, 1.7.0
> Reporter: Sebastian Ortega
> Fix For: 1.7.1
>
> Attachments: 0001-Add-NettyServer-constructor-for-custom-pipelines-with-test.patch
>
>
> When trying to use NettyServer with SSL support I have problems despite [AVRO-898] has been accepted. If I am not wrong, the SSLHandler should be added to the worker pipelines but you cannot do that with the current interface.
> I've prepared a patch of a different approach. I've added a new constructor of type ChannelPipelineFactory used to initialize the worker pipeline instead of calling Channels.pipeline() directly. Please see the attached path.
> If I'm wrong, I wil be very grateful to know how to solve it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-1119) NettyServer support for SSL
Posted by "Sebastian Ortega (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406323#comment-13406323 ]
Sebastian Ortega commented on AVRO-1119:
----------------------------------------
It was a mistake, I've solved it as well as attached the sample certificate used in the unit test.
> NettyServer support for SSL
> ---------------------------
>
> Key: AVRO-1119
> URL: https://issues.apache.org/jira/browse/AVRO-1119
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.6.3, 1.7.0
> Reporter: Sebastian Ortega
> Fix For: 1.7.1
>
> Attachments: 0001-Add-NettyServer-constructor-for-custom-pipelines-with-test.patch, servercert.p12
>
>
> When trying to use NettyServer with SSL support I have problems despite [AVRO-898] has been accepted. If I am not wrong, the SSLHandler should be added to the worker pipelines but you cannot do that with the current interface.
> I've prepared a patch of a different approach. I've added a new constructor of type ChannelPipelineFactory used to initialize the worker pipeline instead of calling Channels.pipeline() directly. Please see the attached path.
> If I'm wrong, I wil be very grateful to know how to solve it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1119) NettyServer support for SSL
Posted by "Sebastian Ortega (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Ortega updated AVRO-1119:
-----------------------------------
Attachment: (was: 0001-Add-NettyServer-constructor-for-custom-pipelines.patch)
> NettyServer support for SSL
> ---------------------------
>
> Key: AVRO-1119
> URL: https://issues.apache.org/jira/browse/AVRO-1119
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.6.3, 1.7.0
> Reporter: Sebastian Ortega
> Fix For: 1.7.1
>
> Attachments: 0001-Add-NettyServer-constructor-for-custom-pipelines-with-test.patch
>
>
> When trying to use NettyServer with SSL support I have problems despite [AVRO-898] has been accepted. If I am not wrong, the SSLHandler should be added to the worker pipelines but you cannot do that with the current interface.
> I've prepared a patch of a different approach. I've added a new constructor of type ChannelPipelineFactory used to initialize the worker pipeline instead of calling Channels.pipeline() directly. Please see the attached path.
> If I'm wrong, I wil be very grateful to know how to solve it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira