You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2012/03/23 06:15:28 UTC
Review Request: Stop components when config timestamp changes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4464/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
Added functionality to support stopping of components if configuration changes.
This addresses bug FLUME-1036.
https://issues.apache.org/jira/browse/FLUME-1036
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java dd757fc
flume-ng-core/src/main/java/org/apache/flume/sink/LoggerSink.java f6f9d33
flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 94245ac
flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 97f72e1
flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java c150097
flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java 47249e9
Diff: https://reviews.apache.org/r/4464/diff
Testing
-------
Tested change of configuration - no bind exception when port remains the same. When port changes, old port is no longer accessible, new port is.
Thanks,
Hari
Re: Review Request: Stop components when config timestamp changes.
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4464/#review6308
-----------------------------------------------------------
Ship it!
+1. Please attach the patch to the Jira.
- Arvind
On 2012-03-23 17:58:44, Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4464/
> -----------------------------------------------------------
>
> (Updated 2012-03-23 17:58:44)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> Added functionality to support stopping of components if configuration changes.
>
>
> This addresses bug FLUME-1036.
> https://issues.apache.org/jira/browse/FLUME-1036
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java dd757fc
> flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 94245ac
> flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 97f72e1
> flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java c150097
>
> Diff: https://reviews.apache.org/r/4464/diff
>
>
> Testing
> -------
>
> Tested change of configuration - no bind exception when port remains the same. When port changes, old port is no longer accessible, new port is.
>
>
> Thanks,
>
> Hari
>
>
Re: Review Request: Stop components when config timestamp changes.
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4464/
-----------------------------------------------------------
(Updated 2012-03-23 17:58:44.921477)
Review request for Flume.
Changes
-------
Incorporated Arvind's feedback.
Summary
-------
Added functionality to support stopping of components if configuration changes.
This addresses bug FLUME-1036.
https://issues.apache.org/jira/browse/FLUME-1036
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java dd757fc
flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 94245ac
flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 97f72e1
flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java c150097
Diff: https://reviews.apache.org/r/4464/diff
Testing
-------
Tested change of configuration - no bind exception when port remains the same. When port changes, old port is no longer accessible, new port is.
Thanks,
Hari
Re: Review Request: Stop components when config timestamp changes.
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4464/#review6277
-----------------------------------------------------------
Thanks for the patch Hari. A couple of suggestions to consider:
* Rather than adding another method in NodeConfigurationAware which is invoked by the PropertiesFIleConfigurationProvider - it will be better to instead keep a track of the old configuration within the DefaultLogicalNodeManager which onNodeConfigurationChanged() invocation first shuts down and removes the old components from last configuration before initializing the new configuration based components.
* Similarly, rather than introducing setStopStateImmediately(), we should instead fix the implementation of unsupervise() to do the necessary shutdown and cleanup.
flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java
<https://reviews.apache.org/r/4464/#comment13618>
this block needs to be indented.
- Arvind
On 2012-03-23 05:21:27, Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4464/
> -----------------------------------------------------------
>
> (Updated 2012-03-23 05:21:27)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> Added functionality to support stopping of components if configuration changes.
>
>
> This addresses bug FLUME-1036.
> https://issues.apache.org/jira/browse/FLUME-1036
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java dd757fc
> flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 94245ac
> flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 97f72e1
> flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java c150097
> flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java 47249e9
>
> Diff: https://reviews.apache.org/r/4464/diff
>
>
> Testing
> -------
>
> Tested change of configuration - no bind exception when port remains the same. When port changes, old port is no longer accessible, new port is.
>
>
> Thanks,
>
> Hari
>
>
Re: Review Request: Stop components when config timestamp changes.
Posted by Hari Shreedharan <hs...@cloudera.com>.
> On 2012-03-23 05:22:51, Brock Noland wrote:
> > flume-ng-core/src/main/java/org/apache/flume/sink/LoggerSink.java, line 67
> > <https://reviews.apache.org/r/4464/diff/1/?file=94851#file94851line67>
> >
> > Is this what you want?
I think you are looking at an older diff. I removed this in r2.
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4464/#review6272
-----------------------------------------------------------
On 2012-03-23 05:21:27, Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4464/
> -----------------------------------------------------------
>
> (Updated 2012-03-23 05:21:27)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> Added functionality to support stopping of components if configuration changes.
>
>
> This addresses bug FLUME-1036.
> https://issues.apache.org/jira/browse/FLUME-1036
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java dd757fc
> flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 94245ac
> flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 97f72e1
> flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java c150097
> flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java 47249e9
>
> Diff: https://reviews.apache.org/r/4464/diff
>
>
> Testing
> -------
>
> Tested change of configuration - no bind exception when port remains the same. When port changes, old port is no longer accessible, new port is.
>
>
> Thanks,
>
> Hari
>
>
Re: Review Request: Stop components when config timestamp changes.
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4464/#review6272
-----------------------------------------------------------
flume-ng-core/src/main/java/org/apache/flume/sink/LoggerSink.java
<https://reviews.apache.org/r/4464/#comment13597>
Is this what you want?
- Brock
On 2012-03-23 05:21:27, Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4464/
> -----------------------------------------------------------
>
> (Updated 2012-03-23 05:21:27)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> Added functionality to support stopping of components if configuration changes.
>
>
> This addresses bug FLUME-1036.
> https://issues.apache.org/jira/browse/FLUME-1036
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java dd757fc
> flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 94245ac
> flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 97f72e1
> flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java c150097
> flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java 47249e9
>
> Diff: https://reviews.apache.org/r/4464/diff
>
>
> Testing
> -------
>
> Tested change of configuration - no bind exception when port remains the same. When port changes, old port is no longer accessible, new port is.
>
>
> Thanks,
>
> Hari
>
>
Re: Review Request: Stop components when config timestamp changes.
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4464/
-----------------------------------------------------------
(Updated 2012-03-23 05:21:27.505890)
Review request for Flume.
Changes
-------
removing some whitespace changes.
Summary
-------
Added functionality to support stopping of components if configuration changes.
This addresses bug FLUME-1036.
https://issues.apache.org/jira/browse/FLUME-1036
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java dd757fc
flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 94245ac
flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 97f72e1
flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java c150097
flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java 47249e9
Diff: https://reviews.apache.org/r/4464/diff
Testing
-------
Tested change of configuration - no bind exception when port remains the same. When port changes, old port is no longer accessible, new port is.
Thanks,
Hari