[jira] [Commented] (CURATOR-386) Allow listener to be passed in to PersistentNode to notify for node creation events

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CURATOR-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15914055#comment-15914055 ] 

ASF GitHub Bot commented on CURATOR-386:
----------------------------------------

Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/curator/pull/198#discussion_r105545812
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java ---
    @@ -117,6 +120,7 @@ public void processResult(CuratorFramework client, CuratorEvent event)
                 {
                     //Update is ok, mark initialisation as complete if required.
                     initialisationComplete();
    +                notifyListeners();
    --- End diff --
    
    the listener is supposed to listen on the node create event, this is the place where we updated the node value, not create.


> Allow listener to be passed in to PersistentNode to notify for node creation events
> -----------------------------------------------------------------------------------
>
>                 Key: CURATOR-386
>                 URL: https://issues.apache.org/jira/browse/CURATOR-386
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Recipes
>    Affects Versions: 3.2.1
>            Reporter: Alex Kira
>            Priority: Minor
>
> I think it would be useful to allow a listener to be passed in to the PersistentNode that would notify when the new node is created. This is useful as some cases such as disconnect / reconnect or when an ephemeral node is deleted and recreated by PersistentNode. In this case, I would like to be able to listen to these even so I can do something like issue a watch on the node.  
> For example:
> ```
> public interface PersistentNodeListener {
>     /**
>      * Called on a persistentNode event when node is created
>      *
>      * @param path Path of the znode
>      * @throws Exception errors
>      */
>     void nodeCreated(String path) throws Exception;
> }
> ```
> I have a code change implementing this and can issue a pull request for this.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)