You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/06 03:48:28 UTC

[GitHub] [pulsar] Jason918 opened a new pull request #13147: [Issue 12958] Use payload size for isExceedMaximumMessageSize

Jason918 opened a new pull request #13147:
URL: https://github.com/apache/pulsar/pull/13147


   <!--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull request.
       Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   Fixes #12958
   
   ### Motivation
   
   See #12958
   
   ### Modifications
   
   Add `Commands.getPayloadSize` for get payload size from headerAndPayload ByteBuf.
   Use this payload size for `isExceedMaximumMessageSize`
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
     - org.apache.pulsar.broker.admin.TopicPoliciesTest#testTopicMaxMessageSizeThreshHold
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
     
   - [x] `no-need-doc` 
   Bug fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jason918 commented on pull request #13147: [Issue 12958] Use payload size for isExceedMaximumMessageSize

Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #13147:
URL: https://github.com/apache/pulsar/pull/13147#issuecomment-987495153


   > It seems that you want to compute the real message payload size, but if the message is a batch message, even we skip the batch message metadata, the rest part will also include many single message metadata.
   
   Yes, this fix is for non-batch messages.
   For batching message, we still need to check the size at client side. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jason918 closed pull request #13147: [Issue 12958] Use payload size for isExceedMaximumMessageSize

Posted by GitBox <gi...@apache.org>.
Jason918 closed pull request #13147:
URL: https://github.com/apache/pulsar/pull/13147


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jason918 commented on pull request #13147: [Issue 12958] Use payload size for isExceedMaximumMessageSize

Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #13147:
URL: https://github.com/apache/pulsar/pull/13147#issuecomment-1016054721


   This will be fixed by PIP-132 in #13591
   Close this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org