You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/26 11:49:58 UTC

[GitHub] [cloudstack-primate] Pearl1594 opened a new pull request #625: Allow migration of detached volumes

Pearl1594 opened a new pull request #625:
URL: https://github.com/apache/cloudstack-primate/pull/625


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #625: Allow migration of detached volumes

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #625:
URL: https://github.com/apache/cloudstack-primate/pull/625#issuecomment-680830920


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #625: Allow migration of detached volumes

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #625:
URL: https://github.com/apache/cloudstack-primate/pull/625#discussion_r478967267



##########
File path: src/config/section/storage.js
##########
@@ -168,7 +168,7 @@ export default {
           label: 'label.migrate.volume',
           args: ['volumeid', 'storageid', 'livemigrate'],
           dataView: true,
-          show: (record, store) => { return record.state === 'Ready' && ['Admin'].includes(store.userInfo.roletype) && record.virtualmachineid },
+          show: (record, store) => { return record.state === 'Ready' && ['Admin'].includes(store.userInfo.roletype) },

Review comment:
       @rhtyd 
   ```
   if (jsonObj.type == "ROOT" || jsonObj.type == "DATADISK") {
     if (jsonObj.state == "Ready" && isAdmin() && jsonObj.virtualmachineid != null) {
       allowedActions.push("migrateVolume");
     }
   }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #625: Allow migration of detached volumes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #625:
URL: https://github.com/apache/cloudstack-primate/pull/625#issuecomment-680834827


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/625 (JID-3379)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd merged pull request #625: Allow migration of detached volumes

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #625:
URL: https://github.com/apache/cloudstack-primate/pull/625


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #625: Allow migration of detached volumes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #625:
URL: https://github.com/apache/cloudstack-primate/pull/625#issuecomment-680831205


   @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #625: Allow migration of detached volumes

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #625:
URL: https://github.com/apache/cloudstack-primate/pull/625#discussion_r478957423



##########
File path: src/config/section/storage.js
##########
@@ -168,7 +168,7 @@ export default {
           label: 'label.migrate.volume',
           args: ['volumeid', 'storageid', 'livemigrate'],
           dataView: true,
-          show: (record, store) => { return record.state === 'Ready' && ['Admin'].includes(store.userInfo.roletype) && record.virtualmachineid },
+          show: (record, store) => { return record.state === 'Ready' && ['Admin'].includes(store.userInfo.roletype) },

Review comment:
       @Pearl1594 @davidjumani do we allow migration of attached VMs, for all hypervisors? What's the logic/check in old UI?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org