You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by Willymontaz <gi...@git.apache.org> on 2018/11/08 13:41:26 UTC
[GitHub] spark pull request #22980: Spark 25973 - Spark History Main page performance...
GitHub user Willymontaz opened a pull request:
https://github.com/apache/spark/pull/22980
Spark 25973 - Spark History Main page performance improvement
HistoryPage.scala counts applications (with a predicate depending on if it is displaying incomplete or complete applications) to check if it must display the dataTable.
Since it only checks if allAppsSize > 0, we could use exists method on the iterator. This way we stop iterating at the first occurence found.
Such a change has been relevant (roughly 12s improvement on page loading) on our cluster that runs tens of thousands of jobs per day.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Willymontaz/spark SPARK-25973
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22980.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22980
----
commit a13ea9d39abd86cb3956a35122d13a2cf87b3a04
Author: William Montaz <w....@...>
Date: 2018-11-07T16:16:57Z
Fix performance issue on History Server main page loading
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22980: Spark 25973 - Spark History Main page performance improv...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22980
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22980: Spark 25973 - Spark History Main page performance improv...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22980
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22980: Spark 25973 - Spark History Main page performance...
Posted by Willymontaz <gi...@git.apache.org>.
Github user Willymontaz closed the pull request at:
https://github.com/apache/spark/pull/22980
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22980: Spark 25973 - Spark History Main page performance improv...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22980
@Willymontaz Could you make a PR against `master` branch.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22980: Spark 25973 - Spark History Main page performance improv...
Posted by Willymontaz <gi...@git.apache.org>.
Github user Willymontaz commented on the issue:
https://github.com/apache/spark/pull/22980
Rebased on master branch
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22980: Spark 25973 - Spark History Main page performance improv...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22980
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org