You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/15 06:57:43 UTC

[GitHub] [incubator-doris] BiteTheDDDDt commented on a diff in pull request #10146: [Refactor] Use iequal to replace boost::iequals

BiteTheDDDDt commented on code in PR #10146:
URL: https://github.com/apache/incubator-doris/pull/10146#discussion_r897602968


##########
be/src/exec/schema_scan_node.cpp:
##########
@@ -158,8 +159,8 @@ Status SchemaScanNode::prepare(RuntimeState* state) {
         // TODO(zhaochun): Is this slow?
         int j = 0;
         for (; j < _src_tuple_desc->slots().size(); ++j) {
-            if (boost::iequals(_dest_tuple_desc->slots()[i]->col_name(),
-                               _src_tuple_desc->slots()[j]->col_name())) {
+            if (iequal(_dest_tuple_desc->slots()[i]->col_name(),

Review Comment:
   maybe we can try to remove boost include



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org