[GitHub] [ozone] umamaheswararao commented on a change in pull request #2996: HDDS-6194. EC: Freon ockg support EC write

[GitBox <gi...@apache.org>]

umamaheswararao commented on a change in pull request #2996:
URL: https://github.com/apache/ozone/pull/2996#discussion_r787015365



##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OzoneClientKeyGenerator.java
##########
@@ -66,23 +66,31 @@
       defaultValue = "4096")
   private int bufferSize;
 
-  @Option(names = { "-F", "--factor" },
-      description = "Replication factor (ONE, THREE)",
-      defaultValue = "THREE"
-  )
-  private ReplicationFactor factor = ReplicationFactor.THREE;
-
   @Option(
       names = "--om-service-id",
       description = "OM Service ID"
   )
   private String omServiceID = null;
 
+  @Option(names = {"--replication"},
+      description =
+          "Replication configuration of the new key. (this is replication "
+              + "specific. for RATIS/STANDALONE you can use ONE or THREE, " +

Review comment:
       STANDALONE --> STAND_ALONE ?

##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OzoneClientKeyGenerator.java
##########
@@ -93,6 +101,8 @@ public Void call() throws Exception {
 
     contentGenerator = new ContentGenerator(keySize, bufferSize);
     metadata = new HashMap<>();
+    replicationConfig = ReplicationConfig.parse(replicationType, replication,

Review comment:
       parse is returning default values even if we pass replication and type as null.
   When we set the EC on bucket, ideally it's not mandatory to pass the type and replication with key as we moved the default configs to server side along with bucket.
   
   Please refer the JIRA: HDDS-6184 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org