You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xmlgraphics.apache.org by je...@apache.org on 2011/04/22 11:30:30 UTC

svn commit: r1095897 - in /xmlgraphics/commons/trunk: src/java/org/apache/xmlgraphics/xmp/XMPSchemaAdapter.java status.xml test/java/org/apache/xmlgraphics/xmp/DateFormattingTest.java

Author: jeremias
Date: Fri Apr 22 09:30:30 2011
New Revision: 1095897

URL: http://svn.apache.org/viewvc?rev=1095897&view=rev
Log:
Bugzilla #51039:
Fixed a bug formatting ISO 8601 dates with negative two-digit time zones.
Submitted by: Florian Barbera Vila Bollain <f.barbera.at.hotmail.fr>

Modified:
    xmlgraphics/commons/trunk/src/java/org/apache/xmlgraphics/xmp/XMPSchemaAdapter.java
    xmlgraphics/commons/trunk/status.xml
    xmlgraphics/commons/trunk/test/java/org/apache/xmlgraphics/xmp/DateFormattingTest.java

Modified: xmlgraphics/commons/trunk/src/java/org/apache/xmlgraphics/xmp/XMPSchemaAdapter.java
URL: http://svn.apache.org/viewvc/xmlgraphics/commons/trunk/src/java/org/apache/xmlgraphics/xmp/XMPSchemaAdapter.java?rev=1095897&r1=1095896&r2=1095897&view=diff
==============================================================================
--- xmlgraphics/commons/trunk/src/java/org/apache/xmlgraphics/xmp/XMPSchemaAdapter.java (original)
+++ xmlgraphics/commons/trunk/src/java/org/apache/xmlgraphics/xmp/XMPSchemaAdapter.java Fri Apr 22 09:30:30 2011
@@ -196,7 +196,7 @@ public class XMPSchemaAdapter {
             } else {
                 sb.append('-');
             }
-            if (zoneOffsetHours < 10) {
+            if (Math.abs(zoneOffsetHours) < 10) {
                 sb.append('0');
             }
             sb.append(Math.abs(zoneOffsetHours));

Modified: xmlgraphics/commons/trunk/status.xml
URL: http://svn.apache.org/viewvc/xmlgraphics/commons/trunk/status.xml?rev=1095897&r1=1095896&r2=1095897&view=diff
==============================================================================
--- xmlgraphics/commons/trunk/status.xml (original)
+++ xmlgraphics/commons/trunk/status.xml Fri Apr 22 09:30:30 2011
@@ -40,6 +40,9 @@
   </contexts>
   <changes>
     <release version="Trunk" date="n/a">
+      <action context="Code" dev="JM" type="fix" fixes-bug="51039" due-to="Florian Barbera Vila Bollain">
+        Fixed a bug formatting ISO 8601 dates with negative two-digit time zones.
+      </action>
       <action context="Code" dev="JM" type="remove">
         Removed dependency on com.sun classes to achieve compatibility with Apache Harmony,
         OpenJDK and possibly other JVMs. 

Modified: xmlgraphics/commons/trunk/test/java/org/apache/xmlgraphics/xmp/DateFormattingTest.java
URL: http://svn.apache.org/viewvc/xmlgraphics/commons/trunk/test/java/org/apache/xmlgraphics/xmp/DateFormattingTest.java?rev=1095897&r1=1095896&r2=1095897&view=diff
==============================================================================
--- xmlgraphics/commons/trunk/test/java/org/apache/xmlgraphics/xmp/DateFormattingTest.java (original)
+++ xmlgraphics/commons/trunk/test/java/org/apache/xmlgraphics/xmp/DateFormattingTest.java Fri Apr 22 09:30:30 2011
@@ -56,6 +56,10 @@ public class DateFormattingTest extends 
         s = XMPSchemaAdapter.formatISO8601Date(dt, TimeZone.getTimeZone("GMT-08:00"));
         assertEquals("2008-02-07T07:11:07-08:00", s);
         assertEquals(dt, XMPSchemaAdapter.parseISO8601Date(s));
+
+        s = XMPSchemaAdapter.formatISO8601Date(dt, TimeZone.getTimeZone("GMT-11:00"));
+        assertEquals("2008-02-07T04:11:07-11:00", s);
+        assertEquals(dt, XMPSchemaAdapter.parseISO8601Date(s));
     }
 
 }



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: commits-help@xmlgraphics.apache.org