[GitHub] [nifi] mattyb149 commented on a change in pull request #4551: NIFI-6061:Abstract DML operations to AbstractDatabaseAdapter and fix Blob problem for PutDatabaseRecord

[GitBox <gi...@apache.org>]

mattyb149 commented on a change in pull request #4551:
URL: https://github.com/apache/nifi/pull/4551#discussion_r494410833



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
##########
@@ -736,24 +735,22 @@ private void executeDML(ProcessContext context, ProcessSession session, FlowFile
             final Integer maxBatchSize = context.getProperty(MAX_BATCH_SIZE).evaluateAttributeExpressions(flowFile).asInteger();
             int currentBatchSize = 0;
             int batchIndex = 0;
-
+            List<List<Object>> valuesLists = new ArrayList<>();

Review comment:
       Populating `valueLists` will involve keeping every field value from every record in memory. For flowfiles with a large number of records, this could blow the heap and cause an OutOfMemory error




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org