[jira] [Created] (TAP5-2511) Named AMD modules cannot be added to JavaScript stack

["Jochen Kemnade (JIRA)" <ji...@apache.org>]

Jochen Kemnade created TAP5-2511:
------------------------------------

             Summary: Named AMD modules cannot be added to JavaScript stack
                 Key: TAP5-2511
                 URL: https://issues.apache.org/jira/browse/TAP5-2511
             Project: Tapestry 5
          Issue Type: Bug
          Components: tapestry-core
    Affects Versions: 5.4
            Reporter: Jochen Kemnade


The {{define}} statement rewriting logic in {{org.apache.tapestry5.internal.services.assets.JavaScriptStackAssemblerImpl.ModuleReader}} breaks stacks with named modules. For example, jquery 3.0-alpha1 (https://cdnjs.cloudflare.com/ajax/libs/jquery/3.0.0-alpha1/jquery.js) uses
{noformat}
define( "jquery", [], function() {
		return jQuery;
	});
{noformat}
The ModuleReader turns that into
{noformat}
define("jquery", "jquery", [], function() {
		return jQuery;
	});
{noformat} which will not work. We should probably not rewrite named define calls.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)