You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/03/18 09:00:37 UTC
[GitHub] [camel-examples] apupier opened a new pull request #84: CAMEL-17821 - Provide camel-debug in a profile
apupier opened a new pull request #84:
URL: https://github.com/apache/camel-examples/pull/84
Currently, Camel textual debugging requires having camel-debug in
dependencies. This is an extra dependency that we do not want at
runtime.
Previously:
* main java example is configured having it at runtime.
* main xml and yaml doesn't have it
I think a possible good practice is to add the dependency in a profile,
for instance named `camel.debug` which can be activated with the
property camel.debug set to true.
This would be nice to be done for all examples but maybe best to start
with the 3 more simple/important main (java), main-xml and main-yaml to
help starting discussion and see the feedback on it.
I think this is even more important for 3.16 as JMX is exposed by
default when the dependency is available.
wondering if a note should be added in readme of the examples
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-examples] essobedo commented on a change in pull request #84: CAMEL-17821 - Provide camel-debug in a profile
Posted by GitBox <gi...@apache.org>.
essobedo commented on a change in pull request #84:
URL: https://github.com/apache/camel-examples/pull/84#discussion_r829825181
##########
File path: examples/main-xml/pom.xml
##########
@@ -113,5 +113,21 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <id>camel.debug</id>
+ <activation>
+ <property>
+ <name>camel.debug</name>
+ <value>true</value>
Review comment:
If so, I believe that you need to document it too as we cannot assume that the user will check the pom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-examples] essobedo commented on pull request #84: CAMEL-17821 - Provide camel-debug in a profile
Posted by GitBox <gi...@apache.org>.
essobedo commented on pull request #84:
URL: https://github.com/apache/camel-examples/pull/84#issuecomment-1072217233
A note in the readme would help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-examples] davsclaus merged pull request #84: CAMEL-17821 - Provide camel-debug in a profile
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #84:
URL: https://github.com/apache/camel-examples/pull/84
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-examples] apupier commented on a change in pull request #84: CAMEL-17821 - Provide camel-debug in a profile
Posted by GitBox <gi...@apache.org>.
apupier commented on a change in pull request #84:
URL: https://github.com/apache/camel-examples/pull/84#discussion_r829823058
##########
File path: examples/main-xml/pom.xml
##########
@@ -113,5 +113,21 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <id>camel.debug</id>
+ <activation>
+ <property>
+ <name>camel.debug</name>
+ <value>true</value>
Review comment:
to let the choice to users to use the profile id or the property. it gives more flexibility
##########
File path: examples/main-xml/pom.xml
##########
@@ -113,5 +113,21 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <id>camel.debug</id>
Review comment:
I think it helps to make it clear that the profile is related to Camel. It avoids potential collision for the user adding profiles for other kind of debug, like a java remote debug, or a springboot specific debug.
##########
File path: examples/main-xml/pom.xml
##########
@@ -113,5 +113,21 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <id>camel.debug</id>
+ <activation>
+ <property>
+ <name>camel.debug</name>
+ <value>true</value>
Review comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-examples] apupier commented on a change in pull request #84: CAMEL-17821 - Provide camel-debug in a profile
Posted by GitBox <gi...@apache.org>.
apupier commented on a change in pull request #84:
URL: https://github.com/apache/camel-examples/pull/84#discussion_r829823058
##########
File path: examples/main-xml/pom.xml
##########
@@ -113,5 +113,21 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <id>camel.debug</id>
+ <activation>
+ <property>
+ <name>camel.debug</name>
+ <value>true</value>
Review comment:
to let the choice to users to use the profile id or the property. it gives more flexibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-examples] essobedo commented on a change in pull request #84: CAMEL-17821 - Provide camel-debug in a profile
Posted by GitBox <gi...@apache.org>.
essobedo commented on a change in pull request #84:
URL: https://github.com/apache/camel-examples/pull/84#discussion_r829821614
##########
File path: examples/main-xml/pom.xml
##########
@@ -113,5 +113,21 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <id>camel.debug</id>
+ <activation>
+ <property>
+ <name>camel.debug</name>
+ <value>true</value>
Review comment:
Why do you need an activation if your goal is to enable it with its id?
##########
File path: examples/main-xml/pom.xml
##########
@@ -113,5 +113,21 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <id>camel.debug</id>
Review comment:
I'm wondering if it is really needed to prefix it by camel? it sounds like a pleonasm to me
##########
File path: examples/main-xml/pom.xml
##########
@@ -113,5 +113,21 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <id>camel.debug</id>
+ <activation>
+ <property>
+ <name>camel.debug</name>
+ <value>true</value>
Review comment:
If so, I believe that you need to document it too as we cannot assume that the user will check the pom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-examples] davsclaus merged pull request #84: CAMEL-17821 - Provide camel-debug in a profile
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #84:
URL: https://github.com/apache/camel-examples/pull/84
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-examples] essobedo commented on a change in pull request #84: CAMEL-17821 - Provide camel-debug in a profile
Posted by GitBox <gi...@apache.org>.
essobedo commented on a change in pull request #84:
URL: https://github.com/apache/camel-examples/pull/84#discussion_r829821614
##########
File path: examples/main-xml/pom.xml
##########
@@ -113,5 +113,21 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <id>camel.debug</id>
+ <activation>
+ <property>
+ <name>camel.debug</name>
+ <value>true</value>
Review comment:
Why do you need an activation if your goal is to enable it with its id?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-examples] apupier commented on a change in pull request #84: CAMEL-17821 - Provide camel-debug in a profile
Posted by GitBox <gi...@apache.org>.
apupier commented on a change in pull request #84:
URL: https://github.com/apache/camel-examples/pull/84#discussion_r829833140
##########
File path: examples/main-xml/pom.xml
##########
@@ -113,5 +113,21 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <id>camel.debug</id>
+ <activation>
+ <property>
+ <name>camel.debug</name>
+ <value>true</value>
Review comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-examples] essobedo commented on pull request #84: CAMEL-17821 - Provide camel-debug in a profile
Posted by GitBox <gi...@apache.org>.
essobedo commented on pull request #84:
URL: https://github.com/apache/camel-examples/pull/84#issuecomment-1072217233
A note in the readme would help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-examples] davsclaus commented on pull request #84: CAMEL-17821 - Provide camel-debug in a profile
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #84:
URL: https://github.com/apache/camel-examples/pull/84#issuecomment-1072223286
I still think Textual Route Debugging is a bad term. It should just be Route Debugging.
The other thing you may think about is Visual Route Debugging, like hawtio is able to do.
So I think the terms should be
- Route Debugging
- Visual Route Debugging (when using hawtio or tools that are visual)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-examples] apupier commented on pull request #84: CAMEL-17821 - Provide camel-debug in a profile
Posted by GitBox <gi...@apache.org>.
apupier commented on pull request #84:
URL: https://github.com/apache/camel-examples/pull/84#issuecomment-1072231239
> I still think Textual Route Debugging is a bad term. It should just be Route Debugging.
>
> The other thing you may think about is Visual Route Debugging, like hawtio is able to do.
>
> So I think the terms should be
>
> * Route Debugging
>
> * Visual Route Debugging (when using hawtio or tools that are visual)
I think "Route debugging" is not precise enough. When using it, it is not clear if we are talking about textual debugging or visual/graphical debugging.
Even "textual route debugging" might not be enough precise here as it is more precisely at the Camel Textual DSL level. it would allow to be able to make the distinction with Camel route debugging using "classic" Java (which can be done using Processors or placing specific breakpoints inside camel core java code).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-examples] davsclaus commented on pull request #84: CAMEL-17821 - Provide camel-debug in a profile
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #84:
URL: https://github.com/apache/camel-examples/pull/84#issuecomment-1072223286
I still think Textual Route Debugging is a bad term. It should just be Route Debugging.
The other thing you may think about is Visual Route Debugging, like hawtio is able to do.
So I think the terms should be
- Route Debugging
- Visual Route Debugging (when using hawtio or tools that are visual)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-examples] essobedo commented on a change in pull request #84: CAMEL-17821 - Provide camel-debug in a profile
Posted by GitBox <gi...@apache.org>.
essobedo commented on a change in pull request #84:
URL: https://github.com/apache/camel-examples/pull/84#discussion_r829823016
##########
File path: examples/main-xml/pom.xml
##########
@@ -113,5 +113,21 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <id>camel.debug</id>
Review comment:
I'm wondering if it is really needed to prefix it by camel? it sounds like a pleonasm to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-examples] apupier commented on pull request #84: CAMEL-17821 - Provide camel-debug in a profile
Posted by GitBox <gi...@apache.org>.
apupier commented on pull request #84:
URL: https://github.com/apache/camel-examples/pull/84#issuecomment-1072231239
> I still think Textual Route Debugging is a bad term. It should just be Route Debugging.
>
> The other thing you may think about is Visual Route Debugging, like hawtio is able to do.
>
> So I think the terms should be
>
> * Route Debugging
>
> * Visual Route Debugging (when using hawtio or tools that are visual)
I think "Route debugging" is not precise enough. When using it, it is not clear if we are talking about textual debugging or visual/graphical debugging.
Even "textual route debugging" might not be enough precise here as it is more precisely at the Camel Textual DSL level. it would allow to be able to make the distinction with Camel route debugging using "classic" Java (which can be done using Processors or placing specific breakpoints inside camel core java code).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-examples] apupier commented on a change in pull request #84: CAMEL-17821 - Provide camel-debug in a profile
Posted by GitBox <gi...@apache.org>.
apupier commented on a change in pull request #84:
URL: https://github.com/apache/camel-examples/pull/84#discussion_r829830940
##########
File path: examples/main-xml/pom.xml
##########
@@ -113,5 +113,21 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <id>camel.debug</id>
Review comment:
I think it helps to make it clear that the profile is related to Camel. It avoids potential collision for the user adding profiles for other kind of debug, like a java remote debug, or a springboot specific debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org