You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/05/30 07:10:23 UTC
[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13469
Change subject: KUDU-2791: TTL cache in DNS resolver (part 2)
......................................................................
KUDU-2791: TTL cache in DNS resolver (part 2)
This changelist adds necessary plumbing in various places where
it's beneficial to use caching DnsResolver instead of
HostPort::ResolveAddresses().
Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc
---
M src/kudu/client/client-internal.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/kserver/kserver.cc
M src/kudu/kserver/kserver.h
M src/kudu/master/master_service.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/ts_descriptor-test.cc
M src/kudu/master/ts_descriptor.cc
M src/kudu/master/ts_descriptor.h
M src/kudu/master/ts_manager.cc
M src/kudu/master/ts_manager.h
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/ts_tablet_manager.cc
20 files changed, 151 insertions(+), 92 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/13469/1
--
To view, visit http://gerrit.cloudera.org:8080/13469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc
Gerrit-Change-Number: 13469
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13469
to look at the new patch set (#4).
Change subject: KUDU-2791: TTL cache in DNS resolver (part 2)
......................................................................
KUDU-2791: TTL cache in DNS resolver (part 2)
This changelist adds necessary plumbing in various places where
it's beneficial to use caching DnsResolver instead of
HostPort::ResolveAddresses().
Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc
---
M src/kudu/client/client-internal.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/kserver/kserver.cc
M src/kudu/master/master_service.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/ts_descriptor-test.cc
M src/kudu/master/ts_descriptor.cc
M src/kudu/master/ts_descriptor.h
M src/kudu/master/ts_manager.cc
M src/kudu/master/ts_manager.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base.h
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/util/net/net_util.cc
22 files changed, 169 insertions(+), 126 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/13469/4
--
To view, visit http://gerrit.cloudera.org:8080/13469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc
Gerrit-Change-Number: 13469
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13469
to look at the new patch set (#3).
Change subject: KUDU-2791: TTL cache in DNS resolver (part 2)
......................................................................
KUDU-2791: TTL cache in DNS resolver (part 2)
This changelist adds necessary plumbing in various places where
it's beneficial to use caching DnsResolver instead of
HostPort::ResolveAddresses().
Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc
---
M src/kudu/client/client-internal.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/kserver/kserver.cc
M src/kudu/master/master_service.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/ts_descriptor-test.cc
M src/kudu/master/ts_descriptor.cc
M src/kudu/master/ts_descriptor.h
M src/kudu/master/ts_manager.cc
M src/kudu/master/ts_manager.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base.h
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/util/net/net_util.cc
22 files changed, 169 insertions(+), 123 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/13469/3
--
To view, visit http://gerrit.cloudera.org:8080/13469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc
Gerrit-Change-Number: 13469
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13469 )
Change subject: KUDU-2791: TTL cache in DNS resolver (part 2)
......................................................................
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/consensus/consensus_peers.cc
File src/kudu/consensus/consensus_peers.cc:
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/consensus/consensus_peers.cc@576
PS2, Line 576: std::
> Can drop this?
Done
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/kserver/kserver.h
File src/kudu/kserver/kserver.h:
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/kserver/kserver.h@65
PS2, Line 65: // Get DNS resolver for this server.
> I might push the DnsResolver into ServerBase, since it's not Kudu-specific
Done
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/kserver/kserver.h@72
PS2, Line 72: std::shared_ptr<DnsResolver> dns_resolver_;
> Why shared ownership?
I thought it might be used by objects which are still alive when KuduServer is already destroyed. That's not the case, it seems: KuduServers are in the top-level in the main() function.
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/master/ts_descriptor.h
File src/kudu/master/ts_descriptor.h:
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/master/ts_descriptor.h@66
PS2, Line 66: std::shared_ptr<DnsResolver> dns_resolver,
> Should be able to pass the DnsResolver as a raw pointer; its lifetime will
Good catch. At some point I thought it would be necessary to keep it in TSDescriptor for further operations, but it seems all TSDescriptors are gone before resolver is destroyed.
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/master/ts_descriptor.cc
File src/kudu/master/ts_descriptor.cc:
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/master/ts_descriptor.cc@144
PS2, Line 144: dns_resolver_ = std::move(dns_resolver);
> Where is this actually used?
Fixed -- it's used in TSDescriptor::ResolveSockaddr()
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/tserver/heartbeater.cc
File src/kudu/tserver/heartbeater.cc:
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/tserver/heartbeater.cc@339
PS2, Line 339: RETURN_NOT_OK(MasterServiceProxyForHostPort(master_address_,
: server_->messenger(),
: server_->dns_resolver().get(),
: &new_proxy));
> Seems like this method would be simpler if it was a member rather than a fr
Done
--
To view, visit http://gerrit.cloudera.org:8080/13469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc
Gerrit-Change-Number: 13469
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 02 Jun 2019 07:24:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13469 )
Change subject: KUDU-2791: TTL cache in DNS resolver (part 2)
......................................................................
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/consensus/consensus_peers.cc
File src/kudu/consensus/consensus_peers.cc:
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/consensus/consensus_peers.cc@576
PS2, Line 576: std::
Can drop this?
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/kserver/kserver.h
File src/kudu/kserver/kserver.h:
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/kserver/kserver.h@65
PS2, Line 65: // Get DNS resolver for this server.
I might push the DnsResolver into ServerBase, since it's not Kudu-specific and could theoretically be useful to any server.
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/kserver/kserver.h@72
PS2, Line 72: std::shared_ptr<DnsResolver> dns_resolver_;
Why shared ownership?
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/master/ts_descriptor.h
File src/kudu/master/ts_descriptor.h:
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/master/ts_descriptor.h@66
PS2, Line 66: std::shared_ptr<DnsResolver> dns_resolver,
Should be able to pass the DnsResolver as a raw pointer; its lifetime will far exceed that of individual objects managed by a server.
Same feedback applies elsewhere.
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/master/ts_descriptor.cc
File src/kudu/master/ts_descriptor.cc:
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/master/ts_descriptor.cc@144
PS2, Line 144: dns_resolver_ = std::move(dns_resolver);
Where is this actually used?
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/tserver/heartbeater.cc
File src/kudu/tserver/heartbeater.cc:
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/tserver/heartbeater.cc@339
PS2, Line 339: RETURN_NOT_OK(MasterServiceProxyForHostPort(master_address_,
: server_->messenger(),
: server_->dns_resolver().get(),
: &new_proxy));
Seems like this method would be simpler if it was a member rather than a free function.
--
To view, visit http://gerrit.cloudera.org:8080/13469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc
Gerrit-Change-Number: 13469
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 31 May 2019 00:03:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13469
to look at the new patch set (#2).
Change subject: KUDU-2791: TTL cache in DNS resolver (part 2)
......................................................................
KUDU-2791: TTL cache in DNS resolver (part 2)
This changelist adds necessary plumbing in various places where
it's beneficial to use caching DnsResolver instead of
HostPort::ResolveAddresses().
Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc
---
M src/kudu/client/client-internal.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/kserver/kserver.cc
M src/kudu/kserver/kserver.h
M src/kudu/master/master_service.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/ts_descriptor-test.cc
M src/kudu/master/ts_descriptor.cc
M src/kudu/master/ts_descriptor.h
M src/kudu/master/ts_manager.cc
M src/kudu/master/ts_manager.h
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/ts_tablet_manager.cc
20 files changed, 149 insertions(+), 91 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/13469/2
--
To view, visit http://gerrit.cloudera.org:8080/13469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc
Gerrit-Change-Number: 13469
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13469 )
Change subject: KUDU-2791: TTL cache in DNS resolver (part 2)
......................................................................
Patch Set 6:
Should we now remove the recommendation to use nscd from the docs?
--
To view, visit http://gerrit.cloudera.org:8080/13469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc
Gerrit-Change-Number: 13469
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 03 Jun 2019 03:56:56 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13469 )
Change subject: KUDU-2791: TTL cache in DNS resolver (part 2)
......................................................................
Patch Set 6:
> > IIRC, nscd caches some other things, like user/group info etc.
>
> I thought that was a downside in some cases.
>
> > Is nscd cumbersome to use?
>
> No, but the leaner the install requirements the better.
Making the install leaner is a noble goal, agree. Then I think it makes sense to make sure the non-nscd case is no worse if running Kudu with this patch and remove the recommendation about using nscd.
--
To view, visit http://gerrit.cloudera.org:8080/13469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc
Gerrit-Change-Number: 13469
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 03 Jun 2019 16:34:51 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13469 )
Change subject: KUDU-2791: TTL cache in DNS resolver (part 2)
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/kserver/kserver.h
File src/kudu/kserver/kserver.h:
http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/kserver/kserver.h@72
PS2, Line 72: gscoped_ptr<ThreadPool> raft_pool_;
> I thought it might be used by objects which are still alive when KuduServer
It might become more of an issue if/when more of our DNS resolution is asynchronous and we're trying to gracefully shutdown servers in tests (see KUDU-2439). But that should be fixed directly, and it's not an issue in production.
--
To view, visit http://gerrit.cloudera.org:8080/13469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc
Gerrit-Change-Number: 13469
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sun, 02 Jun 2019 21:22:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13469 )
Change subject: KUDU-2791: TTL cache in DNS resolver (part 2)
......................................................................
Patch Set 6:
> IIRC, nscd caches some other things, like user/group info etc.
I thought that was a downside in some cases.
> Is nscd cumbersome to use?
No, but the leaner the install requirements the better.
--
To view, visit http://gerrit.cloudera.org:8080/13469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc
Gerrit-Change-Number: 13469
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 03 Jun 2019 16:02:34 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13469 )
Change subject: KUDU-2791: TTL cache in DNS resolver (part 2)
......................................................................
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/13469/3/src/kudu/master/ts_descriptor-test.cc
File src/kudu/master/ts_descriptor-test.cc:
http://gerrit.cloudera.org:8080/#/c/13469/3/src/kudu/master/ts_descriptor-test.cc@37
PS3, Line 37: using std::vector;
> warning: using decl 'vector' is unused [misc-unused-using-decls]
Done
http://gerrit.cloudera.org:8080/#/c/13469/3/src/kudu/master/ts_descriptor-test.cc@38
PS3, Line 38: using strings::Substitute;
> warning: using decl 'Substitute' is unused [misc-unused-using-decls]
Done
http://gerrit.cloudera.org:8080/#/c/13469/3/src/kudu/master/ts_manager.cc
File src/kudu/master/ts_manager.cc:
http://gerrit.cloudera.org:8080/#/c/13469/3/src/kudu/master/ts_manager.cc@153
PS3, Line 153: instance, registration, location, std::move(dns_resolver)));
> warning: std::move of the variable 'dns_resolver' of the trivially-copyable
Done
http://gerrit.cloudera.org:8080/#/c/13469/3/src/kudu/master/ts_manager.cc@156
PS3, Line 156: instance, registration, location, std::move(dns_resolver), &descriptor));
> warning: std::move of the variable 'dns_resolver' of the trivially-copyable
Done
--
To view, visit http://gerrit.cloudera.org:8080/13469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc
Gerrit-Change-Number: 13469
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sun, 02 Jun 2019 15:51:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13469 )
Change subject: KUDU-2791: TTL cache in DNS resolver (part 2)
......................................................................
Patch Set 6:
> Should we now remove the recommendation to use nscd from the docs?
IIRC, nscd caches some other things, like user/group info etc. Is nscd cumbersome to use?
I haven't done integration-style testing for with this patch to verify how Kudu behaves in case of slow DNS servers. I think this patch should help, but it would be interesting to quantify the improvement and make sure we can safely stop recommending nscd.
--
To view, visit http://gerrit.cloudera.org:8080/13469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc
Gerrit-Change-Number: 13469
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 03 Jun 2019 05:16:35 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13469
to look at the new patch set (#5).
Change subject: KUDU-2791: TTL cache in DNS resolver (part 2)
......................................................................
KUDU-2791: TTL cache in DNS resolver (part 2)
This changelist adds necessary plumbing in various places where
it's beneficial to use caching DnsResolver instead of
HostPort::ResolveAddresses().
Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc
---
M src/kudu/client/client-internal.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/kserver/kserver.cc
M src/kudu/master/master_service.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/ts_descriptor-test.cc
M src/kudu/master/ts_descriptor.cc
M src/kudu/master/ts_descriptor.h
M src/kudu/master/ts_manager.cc
M src/kudu/master/ts_manager.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base.h
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/util/net/net_util.cc
22 files changed, 169 insertions(+), 127 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/13469/5
--
To view, visit http://gerrit.cloudera.org:8080/13469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc
Gerrit-Change-Number: 13469
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13469 )
Change subject: KUDU-2791: TTL cache in DNS resolver (part 2)
......................................................................
KUDU-2791: TTL cache in DNS resolver (part 2)
This changelist adds necessary plumbing in various places where
it's beneficial to use caching DnsResolver instead of
HostPort::ResolveAddresses().
Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc
Reviewed-on: http://gerrit.cloudera.org:8080/13469
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/client/client-internal.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/kserver/kserver.cc
M src/kudu/master/master_service.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/ts_descriptor-test.cc
M src/kudu/master/ts_descriptor.cc
M src/kudu/master/ts_descriptor.h
M src/kudu/master/ts_manager.cc
M src/kudu/master/ts_manager.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base.h
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/util/net/net_util.cc
22 files changed, 169 insertions(+), 127 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc
Gerrit-Change-Number: 13469
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)