You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Naveen Gangam (JIRA)" <ji...@apache.org> on 2015/03/02 21:10:04 UTC

[jira] [Commented] (HIVE-9788) Make double quote optional in tsv/csv/dsv output

    [ https://issues.apache.org/jira/browse/HIVE-9788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343683#comment-14343683 ] 

Naveen Gangam commented on HIVE-9788:
-------------------------------------

[~Ferd] 
Thank you for re-working the fix.
"What if the value contains a separator char? "
Based on my limited testing, if the data returned by the result set contains the separator char, the formatted string returned by the CsvListWriter accounted for those characters. Looking at the code, the code appears to add a the quote string around each _quote char_ found in the column value, and then wraps the entire column in a pair of _quotes_.  So to me, it appears that it should work with all sorts of characters within the data.
Could you please elaborate your usecase where this fails?

Also if we do want to retain backward compatibility, would making "disableQuotingForSV" a system property-based instead of commandline option be better suited? It is easier to stop support for a system property(ignore) than for a commandline switch, if and when we stop supporting this option (or if a new version of super-csv becomes available that does not support this). Just my opinion on this. Thanks again

> Make double quote optional in tsv/csv/dsv output
> ------------------------------------------------
>
>                 Key: HIVE-9788
>                 URL: https://issues.apache.org/jira/browse/HIVE-9788
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Brock Noland
>            Assignee: Ferdinand Xu
>         Attachments: HIVE-9788.1.patch, HIVE-9788.patch
>
>
> Similar to HIVE-7390 some customers would like the double quotes to be optional. So if the data is {{"A"}} then the output from beeline should be {{"A"}} which is the same as the Hive CLI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)