You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2021/08/25 13:01:01 UTC
[commons-configuration] branch master updated: Test case and fix
for https://issues.apache.org/jira/browse/CONFIGURATION-808 (#137)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-configuration.git
The following commit(s) were added to refs/heads/master by this push:
new eeae97a Test case and fix for https://issues.apache.org/jira/browse/CONFIGURATION-808 (#137)
eeae97a is described below
commit eeae97a2141dbe1bec8eaab4adfc5338ee2cb38c
Author: cigaly <ci...@users.noreply.github.com>
AuthorDate: Wed Aug 25 15:00:54 2021 +0200
Test case and fix for https://issues.apache.org/jira/browse/CONFIGURATION-808 (#137)
---
.../configuration2/convert/DefaultListDelimiterHandler.java | 2 +-
.../configuration2/convert/TestDefaultListDelimiterHandler.java | 8 ++++++++
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/main/java/org/apache/commons/configuration2/convert/DefaultListDelimiterHandler.java b/src/main/java/org/apache/commons/configuration2/convert/DefaultListDelimiterHandler.java
index ece51f4..1691d12 100644
--- a/src/main/java/org/apache/commons/configuration2/convert/DefaultListDelimiterHandler.java
+++ b/src/main/java/org/apache/commons/configuration2/convert/DefaultListDelimiterHandler.java
@@ -103,7 +103,7 @@ public class DefaultListDelimiterHandler extends AbstractListDelimiterHandler
@Override
public Object escapeList(final List<?> values, final ValueTransformer transformer)
{
- final Object[] escapedValues = new String[values.size()];
+ final Object[] escapedValues = new Object[values.size()];
int idx = 0;
for (final Object v : values)
{
diff --git a/src/test/java/org/apache/commons/configuration2/convert/TestDefaultListDelimiterHandler.java b/src/test/java/org/apache/commons/configuration2/convert/TestDefaultListDelimiterHandler.java
index c80b0c5..238d7f2 100644
--- a/src/test/java/org/apache/commons/configuration2/convert/TestDefaultListDelimiterHandler.java
+++ b/src/test/java/org/apache/commons/configuration2/convert/TestDefaultListDelimiterHandler.java
@@ -110,6 +110,14 @@ public class TestDefaultListDelimiterHandler
handler.escapeList(data, trans));
}
+ @Test
+ public void testEscapeIntegerList()
+ {
+ final ValueTransformer trans = ListDelimiterHandler.NOOP_TRANSFORMER;
+ final List<Integer> data = Arrays.asList(1, 2, 3, 4);
+ assertEquals("1,2,3,4", handler.escapeList(data, trans));
+ }
+
/**
* Helper methods for testing a split operation. A split is executed with
* the passed in parameters. Then the results are compared to the expected