You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/04 21:00:26 UTC

[GitHub] [airflow] eladkal commented on pull request #14078: GoogleDisplayVideo360Hook.download_media does not pass the resourceName correctly

eladkal commented on pull request #14078:
URL: https://github.com/apache/airflow/pull/14078#issuecomment-813098398


   @sarahamilton can you please fix the tests?
   
   ```
   tests/providers/google/marketing_platform/hooks/test_display_video.py:370: 
   _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
   /usr/local/lib/python3.6/unittest/mock.py:825: in assert_called_once_with
       return self.assert_called_with(*args, **kwargs)
   _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
   
   _mock_self = <MagicMock name='get_conn_to_display_video().media().download_media' id='139892921578104'>
   args = (), kwargs = {'resource_name': 'resource_name'}
   expected = ((), {'resource_name': 'resource_name'})
   _error_message = <function NonCallableMock.assert_called_with.<locals>._error_message at 0x7f3b59ac1400>
   actual = call(resourceName='resource_name'), cause = None
   
       def assert_called_with(_mock_self, *args, **kwargs):
           """assert that the mock was called with the specified arguments.
       
           Raises an AssertionError if the args and keyword args passed in are
           different to the last call to the mock."""
           self = _mock_self
           if self.call_args is None:
               expected = self._format_mock_call_signature(args, kwargs)
               raise AssertionError('Expected call: %s\nNot called' % (expected,))
       
           def _error_message():
               msg = self._format_mock_failure_message(args, kwargs)
               return msg
           expected = self._call_matcher((args, kwargs))
           actual = self._call_matcher(self.call_args)
           if expected != actual:
               cause = expected if isinstance(expected, Exception) else None
   >           raise AssertionError(_error_message()) from cause
   E           AssertionError: Expected call: download_media(resource_name='resource_name')
   E           Actual call: download_media(resourceName='resource_name')
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org