Re: [PR] test: Add `datafusion.format.*` configs test coverage [datafusion]

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #21355:
URL: https://github.com/apache/datafusion/pull/21355#discussion_r3046068833


##########
datafusion/sqllogictest/test_files/set_variable.slt:
##########
@@ -379,6 +379,204 @@ RESET datafusion.execution.batches_size
 statement error DataFusion error: Invalid or Unsupported Configuration: Config field is a scalar usize and does not have nested field "bar"
 RESET datafusion.execution.batch_size.bar
 
+#############################################
+## Test datafusion.format.* configurations ##
+#############################################
+query T
+SELECT name FROM information_schema.df_settings WHERE name LIKE 'datafusion.format.%' ORDER BY name

Review Comment:
   > I need to have a look on this. Does it make sense to be merged current PR and extend sqllogictest framework and adding remaining functional tests by follow-up PR? If so, i can create follow-up issue.
   
   
   
   Yes that is an excellent idea. I will do so. Thank you



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org