[GitHub] TaoLv commented on a change in pull request #11047: Enhance mkldnn pooling to support full convention

[GitBox <gi...@apache.org>]

TaoLv commented on a change in pull request #11047: Enhance mkldnn pooling to support full convention
URL: https://github.com/apache/incubator-mxnet/pull/11047#discussion_r190782777
 
 

 ##########
 File path: src/operator/nn/mkldnn/mkldnn_pooling-inl.h
 ##########
 @@ -87,23 +87,8 @@ inline bool SupportMKLDNNPooling(const PoolingParam &param) {
 inline bool SupportMKLDNNPooling(const PoolingParam &param,
                                  const TShape &dshape) {
   bool ret = SupportMKLDNNPooling(param);
-  if (!ret)
-    return false;
 
-  if (param.pooling_convention == pool_enum::kValid)
-    return true;
-  else
-    return false;
-
-// need to support pooling convention full
-// https://issues.apache.org/jira/browse/MXNET-33
-#if 0
-  if (((dshape[2] + 2 * param.pad[0] - param.kernel[0]) % param.stride[0] == 0) &&
-      ((dshape[3] + 2 * param.pad[1] - param.kernel[1]) % param.stride[1] == 0))
-    return true;
-  else
-    return false;
-#endif
 
 Review comment:
   Yes, I think so. Previously, mkldnn pooling operator only supports `pooling_convention=kValid` and it's no need to check shape for kValid. But if we want to support kFull, we need adjust padding size to get correct output shape.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services