You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "chstercc (via GitHub)" <gi...@apache.org> on 2026/10/09 10:46:29 UTC
[PR] fix(web): recover from assistant clipboard write failures [rocketmq-dashboard]
chstercc opened a new pull request, #5799:
URL: https://github.com/apache/rocketmq-dashboard/pull/5799
### Which Issue(s) This PR Fixes
- Fixes #5796
### Brief Description
Attempt the hidden-textarea fallback when Clipboard API writes fail. Handle unsupported or throwing fallback operations silently, always remove the temporary textarea, and show the copied indicator only after successful copying.
Add eight component regression tests covering Clipboard API success and failure, fallback success and failure, and temporary-node cleanup. Verify that copied markdown includes answer text and excludes reasoning blocks.
### How Did You Test This Change?
- `cd web && npm test -- src/pages/ai/components/__tests__/AssistantBubble.test.tsx` — 27 tests passed, including 8 new cases.
- `cd web && npm run lint` — passed with 0 errors and 10 existing warnings.
- `cd web && npm run build` — TypeScript compilation and Vite bundling passed; the final license check failed with `license gate: build artifact verification failed: assets/index-DWfsl_c6.js`. The same failure was reproduced on unchanged upstream `12b63f34`.
- `git diff --check` — passed.
Backend tests and ArchUnit were not run because this change only affects the frontend copy handler and its component tests.
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in
- [x] Commit subject follows Conventional Commits (`feat:` / `fix:` / `refactor:` / `chore:` / `docs:` / `perf:`)
- [x] Tests added or updated for non-trivial changes, test methods named `...Test`
- [x] New UI text has both Chinese and English entries under `web/src/i18n/` — no new UI text
- [ ] Architecture constraints stay green (`mvn test` runs the ArchUnit checks)
- [x] New source files carry the ASF license header — no new source files
- [x] Documentation touched where behaviour changed (README / `docs/` / in-app help) — existing documented fallback behavior restored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): recover from assistant clipboard write failures [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #5799:
URL: https://github.com/apache/rocketmq-dashboard/pull/5799#issuecomment-6093558015
Merged as part of #5782 (squashed into `rocketmq-studio` as cc9a7cd36).
We are consolidating same-author changes into one commit rather than landing several near-identical ones on the trunk; your commit stays visible on this pull request and is credited in the merge body. Closing - no action needed, and thanks for the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): recover from assistant clipboard write failures [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #5799: fix(web): recover from assistant clipboard write failures
URL: https://github.com/apache/rocketmq-dashboard/pull/5799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org