You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "rishabhdaim (via GitHub)" <gi...@apache.org> on 2024/04/15 16:25:19 UTC
[PR] OAK-10763 : fixed the skipping of orphan nodes in case parent is not … [jackrabbit-oak]
rishabhdaim opened a new pull request, #1418:
URL: https://github.com/apache/jackrabbit-oak/pull/1418
…existing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10763 : fixed the skipping of orphan nodes in case parent is not … [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on PR #1418:
URL: https://github.com/apache/jackrabbit-oak/pull/1418#issuecomment-2058580981
As discussed offline I'd argue that an orphan node should be removed entirely - if a gc mode prevents that, it should be skipped. That makes verification stronger and keeps the stats correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10763 : fixed the skipping of orphan nodes in case parent is not … [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim commented on PR #1418:
URL: https://github.com/apache/jackrabbit-oak/pull/1418#issuecomment-2057530328
With https://github.com/apache/jackrabbit-oak/pull/1421 PR, we are skipping the opportunity to clean other types of garbage.
If we want to go via https://github.com/apache/jackrabbit-oak/pull/1421 , we will keep this garbage till we roll out non-gap orphan deletion.
IMO, even with https://github.com/apache/jackrabbit-oak/pull/1421, the logic in this PR is correct i.e. we should be able to delete stuff in case parent/ancestors don't exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10763 : fixed the skipping of orphan nodes in case parent is not … [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim closed pull request #1418: OAK-10763 : fixed the skipping of orphan nodes in case parent is not …
URL: https://github.com/apache/jackrabbit-oak/pull/1418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10763 : fixed the skipping of orphan nodes in case parent is not … [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on PR #1418:
URL: https://github.com/apache/jackrabbit-oak/pull/1418#issuecomment-2057474619
also note my alternative PR suggestion at https://github.com/apache/jackrabbit-oak/pull/1421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org