[GitHub] [incubator-doris] HappenLee commented on a change in pull request #7642: [vectorized] (olap) optimize BlockReader's performance

[GitBox <gi...@apache.org>]

HappenLee commented on a change in pull request #7642:
URL: https://github.com/apache/incubator-doris/pull/7642#discussion_r780373392



##########
File path: be/src/vec/olap/block_reader.cpp
##########
@@ -129,7 +123,7 @@ OLAPStatus BlockReader::init(const ReaderParams& read_params) {
         for (int j = 0; j < read_params.return_columns.size(); ++j) {
             if (read_params.return_columns[j] == cid) {
                 if (j < _tablet->num_key_columns() || _tablet->keys_type() != AGG_KEYS) {
-                    _normal_columns_idx.emplace_back(j);
+                    _normal_columns.emplace_back(i);

Review comment:
       Here should use the `j` not `i`. because the `origin_return_columns` may different with the `return_columns`. here need a map to insert right data in `insert_data_normal`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org