[GitHub] srkukarni commented on a change in pull request #1950: Enable Pulsar Functions to be deployed on a kubernetes cluster

[GitBox <gi...@apache.org>]

srkukarni commented on a change in pull request #1950: Enable Pulsar Functions to be deployed on a kubernetes cluster
URL: https://github.com/apache/pulsar/pull/1950#discussion_r221697998
 
 

 ##########
 File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java
 ##########
 @@ -98,19 +107,19 @@ public void join() throws Exception {
         }
     }
 
-    public CompletableFuture<FunctionStatus> getFunctionStatus() {
-        return runtime.getFunctionStatus().thenApply(f -> {
-            FunctionStatus.Builder builder = FunctionStatus.newBuilder();
-            builder.mergeFrom(f).setNumRestarts(numRestarts).setInstanceId(instanceConfig.getInstanceName());
+    public CompletableFuture<FunctionStatus> getFunctionStatus(int instanceId) {
 
 Review comment:
   Reason is that for an externally managed runtime like kubernetes, the runtime spawner is actually launching an external job which contains the actual instances. Thus we need to pass the instance id of the function of whose data we want

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services