You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/12/08 13:51:38 UTC
[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull
request #3683: modify sharding-jdbc-orchestration-spring-boot-starter for
orchestration-5.x
dongzl commented on a change in pull request #3683: modify sharding-jdbc-orchestration-spring-boot-starter for orchestration-5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/3683#discussion_r355187206
##########
File path: sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/boot/OrchestrationSpringBootConfiguration.java
##########
@@ -108,12 +106,16 @@
*/
@Bean
public OrchestrationConfiguration orchestrationConfiguration() {
- Preconditions.checkState(isValidOrchestrationConfiguration(), "The orchestration configuration is invalid, please configure orchestration name");
- return orchestrationSwapper.swap(orchestrationRule);
+ Preconditions.checkState(isValidOrchestrationConfiguration(), "The orchestration configuration is invalid, please configure orchestration");
+ Map<String, InstanceConfiguration> instanceConfigurationMap = Maps.newHashMapWithExpectedSize(root.getOrchestration().size());
+ for (Map.Entry<String, YamlInstanceConfiguration> each : root.getOrchestration().entrySet()) {
Review comment:
This should use entry instead of each.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services