[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3879: arch: Rename xxx_getsp to up_getsp

[GitBox <gi...@apache.org>]

xiaoxiang781216 edited a comment on pull request #3879:
URL: https://github.com/apache/incubator-nuttx/pull/3879#issuecomment-857624743


   > > Many inlince function(e.g. up_irq_save, up_tls_info) doesn't declare in include/nuttx/, but only in arch/xxx/include/, I just follow this convention.
   > 
   > Yes, that's right, but we still add comments in include/nuttx/arch.h to explain why we don't have a prototype here (e.g. because it's a macro or an inline function).
   > 
   
   Done, the comments is added in include/nuttx/arch.h
   
   > But the convention is `up_` functions are exported outside the arch directory, while `chip_` or ` arch_` are used only inside the arch directory, this is why I asked if we have plans to use this outside arch.
   
   To support TLS, the implementation is already moved from src/up_internal.h into arch/include/arch.h. This PR just make it more clear and avoid the confusion(arm/riscv_xxx prefix in the public arch header files).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org