You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "gosonzhang (via GitHub)" <gi...@apache.org> on 2023/06/07 10:33:30 UTC

[GitHub] [inlong] gosonzhang commented on a diff in pull request #8184: [INLONG-8170][DataProxy] Add inlong_cluster and inlong_cluster_node tables

gosonzhang commented on code in PR #8184:
URL: https://github.com/apache/inlong/pull/8184#discussion_r1221355596


##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/config/pojo/IdTopicConfig.java:
##########
@@ -78,16 +85,23 @@ public void setInlongGroupIdAndStreamId(String inlongGroupId, String inlongStrea
 
     public String getPulsarTopicName(String clusterTenant, String clusterNameSpace) {
         StringBuilder builder = new StringBuilder(256);
-        if (clusterTenant != null) {
-            builder.append(clusterTenant).append("/");
-        }
-        String namespace = clusterNameSpace;
-        if (namespace == null) {
-            namespace = this.nameSpace;
+        // build tenant
+        if (StringUtils.isBlank(tenant)) {

Review Comment:
   @fuweng11, this is written on purpose to avoid negation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org