[GitHub] [beam] reuvenlax commented on a diff in pull request #25094: Externalizing the StreamWriter parameters for StorageWrites

[GitBox <gi...@apache.org>]

reuvenlax commented on code in PR #25094:
URL: https://github.com/apache/beam/pull/25094#discussion_r1082144502


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryOptions.java:
##########
@@ -109,6 +109,20 @@
 
   void setNumStorageWriteApiStreamAppendClients(Integer value);
 
+  @Description(
+      "The max number of messages inflight that we expect each connection will have when connection pool usage is enabled for storage writes.")
+  @Default.Long(1000)
+  Long getStorageWriteMaxInflightRequests();
+
+  void setStorageWriteMaxInflightRequests(Long value);
+
+  @Description(
+      "The max size in bytes for inflight messages that we expect each connection will have when connection pool usage is enabled for storage writes.")

Review Comment:
   Nit: this takes effect whether connection pooling is enabled or not.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org