You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2018/07/18 03:12:20 UTC
[Impala-ASF-CR] [DOCS] Fix UPDATE/UPSERT/DELETE authorization doc
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10975
Change subject: [DOCS] Fix UPDATE/UPSERT/DELETE authorization doc
......................................................................
[DOCS] Fix UPDATE/UPSERT/DELETE authorization doc
The patch also fixes broken links in the authorization doc.
Change-Id: I9bf6109636e44ca514cfe74fb565f7c506ec0708
---
M docs/shared/impala_common.xml
M docs/topics/impala_authorization.xml
2 files changed, 8 insertions(+), 249 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/10975/1
--
To view, visit http://gerrit.cloudera.org:8080/10975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9bf6109636e44ca514cfe74fb565f7c506ec0708
Gerrit-Change-Number: 10975
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] [DOCS] Fix UPDATE/UPSERT/DELETE authorization doc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10975 )
Change subject: [DOCS] Fix UPDATE/UPSERT/DELETE authorization doc
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bf6109636e44ca514cfe74fb565f7c506ec0708
Gerrit-Change-Number: 10975
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Jul 2018 21:30:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fix UPDATE/UPSERT/DELETE authorization doc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10975 )
Change subject: [DOCS] Fix UPDATE/UPSERT/DELETE authorization doc
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/348/
--
To view, visit http://gerrit.cloudera.org:8080/10975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bf6109636e44ca514cfe74fb565f7c506ec0708
Gerrit-Change-Number: 10975
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Jul 2018 21:20:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fix UPDATE/UPSERT/DELETE authorization doc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10975 )
Change subject: [DOCS] Fix UPDATE/UPSERT/DELETE authorization doc
......................................................................
[DOCS] Fix UPDATE/UPSERT/DELETE authorization doc
The patch also fixes broken links in the authorization doc.
Change-Id: I9bf6109636e44ca514cfe74fb565f7c506ec0708
Reviewed-on: http://gerrit.cloudera.org:8080/10975
Reviewed-by: Fredy Wijaya <fw...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/shared/impala_common.xml
M docs/topics/impala_authorization.xml
2 files changed, 339 insertions(+), 1,076 deletions(-)
Approvals:
Fredy Wijaya: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9bf6109636e44ca514cfe74fb565f7c506ec0708
Gerrit-Change-Number: 10975
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] [DOCS] Fix UPDATE/UPSERT/DELETE authorization doc
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10975 )
Change subject: [DOCS] Fix UPDATE/UPSERT/DELETE authorization doc
......................................................................
Patch Set 3:
Fixed the previous merges that went very wrong.
--
To view, visit http://gerrit.cloudera.org:8080/10975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bf6109636e44ca514cfe74fb565f7c506ec0708
Gerrit-Change-Number: 10975
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Jul 2018 18:46:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fix UPDATE/UPSERT/DELETE authorization doc
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has uploaded a new patch set (#3) to the change originally created by Fredy Wijaya. ( http://gerrit.cloudera.org:8080/10975 )
Change subject: [DOCS] Fix UPDATE/UPSERT/DELETE authorization doc
......................................................................
[DOCS] Fix UPDATE/UPSERT/DELETE authorization doc
The patch also fixes broken links in the authorization doc.
Change-Id: I9bf6109636e44ca514cfe74fb565f7c506ec0708
---
M docs/shared/impala_common.xml
M docs/topics/impala_authorization.xml
2 files changed, 339 insertions(+), 1,076 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/10975/3
--
To view, visit http://gerrit.cloudera.org:8080/10975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9bf6109636e44ca514cfe74fb565f7c506ec0708
Gerrit-Change-Number: 10975
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] [DOCS] Fix UPDATE/UPSERT/DELETE authorization doc
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10975 )
Change subject: [DOCS] Fix UPDATE/UPSERT/DELETE authorization doc
......................................................................
[DOCS] Fix UPDATE/UPSERT/DELETE authorization doc
The patch also fixes broken links in the authorization doc.
Change-Id: I9bf6109636e44ca514cfe74fb565f7c506ec0708
---
M docs/shared/impala_common.xml
M docs/topics/impala_authorization.xml
2 files changed, 8 insertions(+), 249 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/10975/2
--
To view, visit http://gerrit.cloudera.org:8080/10975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9bf6109636e44ca514cfe74fb565f7c506ec0708
Gerrit-Change-Number: 10975
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] [DOCS] Fix UPDATE/UPSERT/DELETE authorization doc
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10975 )
Change subject: [DOCS] Fix UPDATE/UPSERT/DELETE authorization doc
......................................................................
Patch Set 3: Code-Review+2
> Patch Set 3:
>
> Fixed the previous merges that went very wrong.
Thanks for the fix, it looks good now. I ran the doc build and there were only few broken link errors, which we should fix in a different CR.
--
To view, visit http://gerrit.cloudera.org:8080/10975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bf6109636e44ca514cfe74fb565f7c506ec0708
Gerrit-Change-Number: 10975
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Jul 2018 18:54:23 +0000
Gerrit-HasComments: No