You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "SamaSVM (via GitHub)" <gi...@apache.org> on 2026/02/24 06:40:17 UTC

[PR] FINERACT-2305: Remove accrual transactions for None and Cash accounti… [fineract]

SamaSVM opened a new pull request, #5535:
URL: https://github.com/apache/fineract/pull/5535

   …ng types at disbursement
   
   ## Description
   
   Loan interest accrual transactions were being created at disbursement for loans with None and Cash accounting types. The fix restricts accrual transaction creation to Accrual Upfront accounting only, which is the only type where upfront accruals are expected. Existing tests updated and a new integration test added to cover all four accounting types.  
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
   - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made.
   - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
   - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
   - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute).
   
   Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2305: Remove accrual transactions for None and Cash accounti… [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #5535:
URL: https://github.com/apache/fineract/pull/5535


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2305: Remove accrual transactions for None and Cash accounti… [fineract]

Posted by "SamaSVM (via GitHub)" <gi...@apache.org>.
SamaSVM commented on code in PR #5535:
URL: https://github.com/apache/fineract/pull/5535#discussion_r2924699299


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanAccrualsProcessingServiceImpl.java:
##########
@@ -209,7 +209,7 @@ public void reprocessExistingAccruals(@NonNull final Loan loan, final boolean ad
         if (!accrualTransactions.isEmpty()) {
             if (loan.isPeriodicAccrualAccountingEnabledOnLoanProduct()) {
                 reprocessPeriodicAccruals(loan, accrualTransactions, addEvent);
-            } else if (loan.isNoneOrCashOrUpfrontAccrualAccountingEnabledOnLoanProduct()) {
+            } else if (!loan.isPeriodicAccrualAccountingEnabledOnLoanProduct()) {

Review Comment:
   You’re right. I’ve updated it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2305: Remove accrual transactions for None and Cash accounti… [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5535:
URL: https://github.com/apache/fineract/pull/5535#issuecomment-3950427199

   @bharathc27 I am not sure about this. Can you please take a look at?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2305: Remove accrual transactions for None and Cash accounti… [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5535:
URL: https://github.com/apache/fineract/pull/5535#issuecomment-3950422433

   @SamaSVM Please rebase with latest `develop` branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2305: Remove accrual transactions for None and Cash accounti… [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5535:
URL: https://github.com/apache/fineract/pull/5535#discussion_r2905899598


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanAccrualsProcessingServiceImpl.java:
##########
@@ -209,7 +209,7 @@ public void reprocessExistingAccruals(@NonNull final Loan loan, final boolean ad
         if (!accrualTransactions.isEmpty()) {
             if (loan.isPeriodicAccrualAccountingEnabledOnLoanProduct()) {
                 reprocessPeriodicAccruals(loan, accrualTransactions, addEvent);
-            } else if (loan.isNoneOrCashOrUpfrontAccrualAccountingEnabledOnLoanProduct()) {
+            } else if (!loan.isPeriodicAccrualAccountingEnabledOnLoanProduct()) {

Review Comment:
   Should this rather cover Accrual_upfront only?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2305: Remove accrual transactions for None and Cash accounti… [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5535:
URL: https://github.com/apache/fineract/pull/5535#issuecomment-4134726990

   @SamaSVM Please raise a new PR with the requested global configuration flag!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org