You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Imbruced (via GitHub)" <gi...@apache.org> on 2024/07/10 14:31:10 UTC
[PR] Airbyte ol integration [airflow]
Imbruced opened a new pull request, #40689:
URL: https://github.com/apache/airflow/pull/40689
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**Add open lineage data from airbyte operator**
This mr aims to add ol support for airbyte operator. It adds schema and column level lineage and simple statistics with number rows. Code is tested with unit tests and also manually verified using local apache airflow instance.
PR is using v2 version of ol objects but OperatorLineage is only working with v1 version, so its locked until migration. What I understand it's blocked by this mr https://github.com/apache/airflow/pull/39530.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Airbyte ol integration [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #40689:
URL: https://github.com/apache/airflow/pull/40689#discussion_r1691731785
##########
airflow/providers/airbyte/hooks/validation.py:
##########
Review Comment:
why is this file under hook directory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Airbyte ol integration [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #40689:
URL: https://github.com/apache/airflow/pull/40689#discussion_r1691782157
##########
airflow/providers/airbyte/hooks/validation.py:
##########
Review Comment:
but this is not a hook... it's confusing.
Some users may not even know what OL is or what this file is about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Airbyte ol integration [airflow]
Posted by "mobuchowski (via GitHub)" <gi...@apache.org>.
mobuchowski commented on code in PR #40689:
URL: https://github.com/apache/airflow/pull/40689#discussion_r1692787179
##########
airflow/providers/airbyte/hooks/validation.py:
##########
Review Comment:
I think it would be the best to put in under `utils` IMO, it's not really tied to particular hook other than "code proximity".
##########
airflow/providers/airbyte/hooks/airbyte.py:
##########
@@ -257,3 +271,125 @@ def test_connection(self):
return False, str(e)
finally:
self.method = "POST"
+
+ def get_airbyte_connection_info(self, connection_id: str) -> dict[str, Any] | None:
+ """
+ Get the connection info for Airbyte.
+
+ :return: The connection info for Airbyte.
+ """
+ if self.api_type == "config":
+ res = self.run(
+ endpoint=f"api/{self.api_version}/connections/get",
+ headers={
+ "accept": "application/json",
+ "authorization": f"Bearer {self.airbyte_connection.password}",
+ },
+ json={
+ "connectionId": connection_id,
+ },
+ )
+
+ if res.status_code != 200:
+ self.log.error("Error getting connection info: %s", res.text)
+ return None
+
+ valid_connection = is_connection_valid(res.json())
+ if not valid_connection:
+ self.log.warning("Connection is not valid")
Review Comment:
I think it would be best to explain more in the warning what means that connection is not valid - unless this is something well known by Airbyte users - who I am not 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Airbyte ol integration [airflow]
Posted by "Imbruced (via GitHub)" <gi...@apache.org>.
Imbruced commented on code in PR #40689:
URL: https://github.com/apache/airflow/pull/40689#discussion_r1691775499
##########
airflow/providers/airbyte/hooks/validation.py:
##########
Review Comment:
to keep it close the place where validation happens :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Airbyte ol integration [airflow]
Posted by "Imbruced (via GitHub)" <gi...@apache.org>.
Imbruced commented on PR #40689:
URL: https://github.com/apache/airflow/pull/40689#issuecomment-2248351156
WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Airbyte ol integration [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40689:
URL: https://github.com/apache/airflow/pull/40689#issuecomment-2372031698
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Airbyte ol integration [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #40689:
URL: https://github.com/apache/airflow/pull/40689#discussion_r1691815751
##########
airflow/providers/airbyte/hooks/validation.py:
##########
Review Comment:
Lets hear from @mobuchowski as I assume this isn't just about Airbyte but for any other integration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Airbyte ol integration [airflow]
Posted by "Imbruced (via GitHub)" <gi...@apache.org>.
Imbruced commented on code in PR #40689:
URL: https://github.com/apache/airflow/pull/40689#discussion_r1691814080
##########
airflow/providers/airbyte/hooks/validation.py:
##########
Review Comment:
Based on hook methods (validation is making sure the schema is ok for connection output). I am not pushing to keep it there, where do you think is the best place to put it ? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Airbyte ol integration [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #40689:
URL: https://github.com/apache/airflow/pull/40689#issuecomment-2220676726
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Airbyte ol integration [airflow]
Posted by "marcosmarxm (via GitHub)" <gi...@apache.org>.
marcosmarxm commented on PR #40689:
URL: https://github.com/apache/airflow/pull/40689#issuecomment-2258623987
@lmaczulajtys can this wait until https://github.com/apache/airflow/pull/41122 get done? I'm trying to replace the API auth method and start using the official Python API SDK to run all operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org