You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by mohammadshahidkhan <gi...@git.apache.org> on 2016/08/10 08:58:26 UTC
[GitHub] incubator-carbondata pull request #71: CARBONDATA-155 Code refactor to avoid...
GitHub user mohammadshahidkhan opened a pull request:
https://github.com/apache/incubator-carbondata/pull/71
CARBONDATA-155 Code refactor to avoid the Type Casting in compareTo method
\u2026
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mohammadshahidkhan/incubator-carbondata code_refactoring
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/71.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #71
----
commit 0683c850579b4852b100cca6cd311d3c90062213
Author: mohammadshahidkhan <mo...@gmail.com>
Date: 2016-08-10T08:57:17Z
CARBONDATA-155 Code refactor to avoid the Type Casting in compareTo method
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #71: [CARBONDATA-155] Code refactor to avoid the ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/71
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1081/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #71: CARBONDATA-155 Code refactor to avoid the Ty...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/71
Build Failed, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #71: CARBONDATA-155 Code refactor to avoid the Ty...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/71
@mohammadshahidkhan are you still working on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #71: CARBONDATA-155 Code refactor to avoid...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/71#discussion_r74879445
--- Diff: core/src/main/java/org/carbondata/core/carbon/datastore/block/Distributable.java ---
@@ -19,7 +19,7 @@
/**
* Abstract class which is maintains the locations of node.
*/
-public abstract class Distributable implements Comparable<Distributable> {
+public abstract class Distributable<T> implements Comparable<T> {
--- End diff --
Yes I agree with @PraveenAdlakha
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #71: CARBONDATA-155 Code refactor to avoid...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/71#discussion_r74250267
--- Diff: core/src/main/java/org/carbondata/core/carbon/datastore/block/Distributable.java ---
@@ -19,7 +19,7 @@
/**
* Abstract class which is maintains the locations of node.
*/
-public abstract class Distributable implements Comparable<Distributable> {
+public abstract class Distributable<T> implements Comparable<T> {
--- End diff --
@PraveenAdlakha Thanks for review will fix the same
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #71: CARBONDATA-155 Code refactor to avoid...
Posted by PraveenAdlakha <gi...@git.apache.org>.
Github user PraveenAdlakha commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/71#discussion_r74214738
--- Diff: core/src/main/java/org/carbondata/core/carbon/datastore/block/Distributable.java ---
@@ -19,7 +19,7 @@
/**
* Abstract class which is maintains the locations of node.
*/
-public abstract class Distributable implements Comparable<Distributable> {
+public abstract class Distributable<T> implements Comparable<T> {
--- End diff --
having T extends Distributable will make better as we can limit the usage to the classes which are extending Distributable
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---