You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2013/11/18 14:45:30 UTC
svn commit: r1543028 -
/tomcat/trunk/java/org/apache/catalina/WebResourceRoot.java
Author: markt
Date: Mon Nov 18 13:45:30 2013
New Revision: 1543028
URL: http://svn.apache.org/r1543028
Log:
Minor clean-up
- inner class to end of file
- no need for public modifiers in interface
Modified:
tomcat/trunk/java/org/apache/catalina/WebResourceRoot.java
Modified: tomcat/trunk/java/org/apache/catalina/WebResourceRoot.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/WebResourceRoot.java?rev=1543028&r1=1543027&r2=1543028&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/WebResourceRoot.java (original)
+++ tomcat/trunk/java/org/apache/catalina/WebResourceRoot.java Mon Nov 18 13:45:30 2013
@@ -391,16 +391,16 @@ public interface WebResourceRoot extends
* the implementation a method that executes periodic tasks, such as purging
* expired cache entries.
*/
- public void backgroundProcess();
+ void backgroundProcess();
- public static enum ResourceSetType {
+ void registerTracedResource(WebResourceTraceWrapper traceWrapper);
+
+ void deregisterTracedResource(WebResourceTraceWrapper traceWrapperInputStream);
+
+ static enum ResourceSetType {
PRE,
RESOURCE_JAR,
POST,
CLASSES_JAR
}
-
- void registerTracedResource(WebResourceTraceWrapper traceWrapper);
-
- void deregisterTracedResource(WebResourceTraceWrapper traceWrapperInputStream);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1543028 - /tomcat/trunk/java/org/apache/catalina/WebResourceRoot.java
Posted by Konstantin Kolinko <kn...@gmail.com>.
2013/11/18 <ma...@apache.org>:
> Author: markt
> Date: Mon Nov 18 13:45:30 2013
> New Revision: 1543028
>
> URL: http://svn.apache.org/r1543028
> Log:
> Minor clean-up
> - inner class to end of file
It would better to move it to the top of the file. That is, introduce
it before it is used to declare method arguments.
There is no javadoc this enum. There is some description for this
interface as a whole, but it does not match the constant names. The
javadoc talks about 'Main', but there is no such constant in the enum.
> - no need for public modifiers in interface
>
Best regards,
Konstantin Kolinko
> Modified:
> tomcat/trunk/java/org/apache/catalina/WebResourceRoot.java
>
> Modified: tomcat/trunk/java/org/apache/catalina/WebResourceRoot.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/WebResourceRoot.java?rev=1543028&r1=1543027&r2=1543028&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/catalina/WebResourceRoot.java (original)
> +++ tomcat/trunk/java/org/apache/catalina/WebResourceRoot.java Mon Nov 18 13:45:30 2013
> @@ -391,16 +391,16 @@ public interface WebResourceRoot extends
> * the implementation a method that executes periodic tasks, such as purging
> * expired cache entries.
> */
> - public void backgroundProcess();
> + void backgroundProcess();
>
> - public static enum ResourceSetType {
> + void registerTracedResource(WebResourceTraceWrapper traceWrapper);
> +
> + void deregisterTracedResource(WebResourceTraceWrapper traceWrapperInputStream);
> +
> + static enum ResourceSetType {
> PRE,
> RESOURCE_JAR,
> POST,
> CLASSES_JAR
> }
> -
> - void registerTracedResource(WebResourceTraceWrapper traceWrapper);
> -
> - void deregisterTracedResource(WebResourceTraceWrapper traceWrapperInputStream);
> }
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org