You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Guangya Liu (JIRA)" <ji...@apache.org> on 2015/12/08 04:54:10 UTC

[jira] [Created] (MESOS-4093) Unify namespace order in mesos code

Guangya Liu created MESOS-4093:
----------------------------------

             Summary: Unify namespace order in mesos code
                 Key: MESOS-4093
                 URL: https://issues.apache.org/jira/browse/MESOS-4093
             Project: Mesos
          Issue Type: Bug
            Reporter: Guangya Liu


This is from code review for https://reviews.apache.org/r/40995/

There is no rule for where to put std namespace.

Style 1)
{code}
using process::Clock;
using process::Future;
using process::Message;
using process::PID;

using std::vector;
{code}

Style 2)
{code}
using std::string;
using std::vector;

using google::protobuf::RepeatedPtrField;

using mesos::internal::master::Master;

using mesos::internal::slave::Slave;

using mesos::quota::QuotaInfo;

using process::Future;
using process::PID;

using process::http::BadRequest;
using process::http::Conflict;
using process::http::OK;
using process::http::Response;
{code}

I think that we should always follow style 2) to make sure putting std at the beginning as it is system library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)